Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: components/devtools_discovery/devtools_target_descriptor.h

Issue 2263843002: DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing 3 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/devtools_discovery/devtools_target_descriptor.h
diff --git a/components/devtools_discovery/devtools_target_descriptor.h b/components/devtools_discovery/devtools_target_descriptor.h
index d7446319910b1361959ca552d5e246fc4498306a..482c07859eced7847cbc0dd46e02653f6bf37472 100644
--- a/components/devtools_discovery/devtools_target_descriptor.h
+++ b/components/devtools_discovery/devtools_target_descriptor.h
@@ -27,41 +27,8 @@ class DevToolsTargetDescriptor {
using List = std::vector<DevToolsTargetDescriptor*>;
virtual ~DevToolsTargetDescriptor() {}
- // Returns the unique target id.
- virtual std::string GetId() const = 0;
-
- // Returns the id of the parent target, or empty string if no parent.
- virtual std::string GetParentId() const = 0;
-
- // Returns the target type.
- virtual std::string GetType() const = 0;
-
- // Returns the target title.
- virtual std::string GetTitle() const = 0;
-
- // Returns the target description.
- virtual std::string GetDescription() const = 0;
-
- // Returns the url associated with this target.
- virtual GURL GetURL() const = 0;
-
- // Returns the favicon url for this target.
- virtual GURL GetFaviconURL() const = 0;
-
- // Returns the time when the target was last active.
- virtual base::TimeTicks GetLastActivityTime() const = 0;
-
- // Returns true if the debugger is attached to the target.
- virtual bool IsAttached() const = 0;
-
// Returns the agent host for this target.
virtual scoped_refptr<content::DevToolsAgentHost> GetAgentHost() const = 0;
-
- // Activates the target. Returns false if the operation failed.
- virtual bool Activate() const = 0;
-
- // Closes the target. Returns false if the operation failed.
- virtual bool Close() const = 0;
};
} // namespace devtools_discovery
« no previous file with comments | « components/devtools_discovery/devtools_discovery_manager.cc ('k') | components/devtools_http_handler/devtools_http_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698