components/devtools_discovery/devtools_discovery_manager.cc - Issue 2263843002: DevTools: merge devtools target with devtools host, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/devtools_discovery/devtools_discovery_manager.cc

Issue 2263843002: DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 3 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/devtools_discovery/basic_target_descriptor.cc ('k') | components/devtools_discovery/devtools_target_descriptor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/devtools_discovery/devtools_discovery_manager.cc

diff --git a/components/devtools_discovery/devtools_discovery_manager.cc b/components/devtools_discovery/devtools_discovery_manager.cc

index f89d0a2e83a8ad1241d5b0eb8bb38a051044dd0f..d7900cd390be30e59eeda9683e798a70e95a1987 100644

--- a/components/devtools_discovery/devtools_discovery_manager.cc

+++ b/components/devtools_discovery/devtools_discovery_manager.cc

@@ -82,7 +82,7 @@ DevToolsDiscoveryManager::HandleCreateTargetCommand(

result->SetInteger("id", id);

std::unique_ptr<base::DictionaryValue> cmd_result(

new base::DictionaryValue());

- cmd_result->SetString("targetId", descriptor->GetId());

+ cmd_result->SetString("targetId", descriptor->GetAgentHost()->GetId());

result->Set("result", std::move(cmd_result));

return result;

}