Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2259283003: Mojo C++ bindings: share DataView class between chromium and blink variants. (Closed)

Created:
4 years, 4 months ago by yzshen1
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@92_change_traits_param
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: share DataView class between chromium and blink variants. In order to do that, this CL changes all the serialization code to use DataView classes to indicate the mojom definitions, rather than using the wrapper classes. BUG=632061 Committed: https://crrev.com/6dc903529d337fbc824b20347be2c4f69197ca8b Cr-Commit-Position: refs/heads/master@{#414028}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Add a test #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+920 lines, -674 lines) Patch
M mojo/public/cpp/bindings/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/array_data_view.h View 11 chunks +50 lines, -37 lines 0 comments Download
A mojo/public/cpp/bindings/interface_data_view.h View 1 chunk +25 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/array_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/array_serialization.h View 4 chunks +4 lines, -11 lines 0 comments Download
M mojo/public/cpp/bindings/lib/bindings_internal.h View 1 2 3 10 chunks +20 lines, -80 lines 0 comments Download
M mojo/public/cpp/bindings/lib/control_message_handler.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/control_message_proxy.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M mojo/public/cpp/bindings/lib/handle_interface_serialization.h View 5 chunks +19 lines, -8 lines 0 comments Download
M mojo/public/cpp/bindings/lib/map_serialization.h View 4 chunks +10 lines, -10 lines 0 comments Download
M mojo/public/cpp/bindings/lib/native_struct_serialization.h View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/native_struct_serialization.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/pipe_control_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/serialization.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/string_serialization.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/map_data_view.h View 3 chunks +6 lines, -11 lines 0 comments Download
M mojo/public/cpp/bindings/tests/array_common_test.h View 6 chunks +26 lines, -26 lines 0 comments Download
M mojo/public/cpp/bindings/tests/data_view_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/tests/map_common_test.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/rect_blink.typemap View 1 2 1 chunk +12 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/rect_blink_traits.h View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/rect_chromium.typemap View 1 2 1 chunk +12 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc View 4 chunks +40 lines, -26 lines 0 comments Download
A mojo/public/cpp/bindings/tests/shared_rect.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A mojo/public/cpp/bindings/tests/shared_rect_traits.h View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_traits_unittest.cc View 1 2 6 chunks +38 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_unittest.cc View 10 chunks +42 lines, -32 lines 0 comments Download
M mojo/public/cpp/bindings/tests/union_unittest.cc View 36 chunks +147 lines, -125 lines 0 comments Download
M mojo/public/cpp/bindings/tests/wtf_types_unittest.cc View 4 chunks +26 lines, -21 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/rect.mojom View 1 2 1 chunk +11 lines, -2 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/test_native_types.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl View 1 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module-shared.h.tmpl View 1 2 3 4 chunks +149 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl View 2 chunks +2 lines, -21 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 9 chunks +2 lines, -41 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl View 2 chunks +22 lines, -7 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl View 2 chunks +4 lines, -28 lines 0 comments Download
D mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl View 1 chunk +0 lines, -14 lines 0 comments Download
A mojo/public/tools/bindings/generators/cpp_templates/struct_traits_declaration.tmpl View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/struct_traits_definition.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_data_view_declaration.tmpl View 2 chunks +18 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl View 4 chunks +6 lines, -35 lines 0 comments Download
D mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl View 1 chunk +0 lines, -42 lines 0 comments Download
A mojo/public/tools/bindings/generators/cpp_templates/union_traits_declaration.tmpl View 1 chunk +30 lines, -0 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/union_traits_definition.tmpl View 1 chunk +6 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/validation_macros.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 4 chunks +22 lines, -27 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/module.py View 1 2 3 2 chunks +9 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 3 months ago (2016-08-22 22:50:38 UTC) #4
Ken Rockot(use gerrit already)
lgtm!
4 years, 3 months ago (2016-08-23 16:02:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259283003/60001
4 years, 3 months ago (2016-08-24 06:26:35 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-24 09:13:19 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 09:15:12 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6dc903529d337fbc824b20347be2c4f69197ca8b
Cr-Commit-Position: refs/heads/master@{#414028}

Powered by Google App Engine
This is Rietveld 408576698