Mojo C++ bindings: change the first template parameter of StructTraits and UnionTraits.

Mojo C++ bindings: change the first template parameter of StructTraits and UnionTraits.

Previously the type is the auto-generated struct/union type. This CL changes it to the corresponding DataView type.

The reason of doing this? The DataView type is shared by the chromium and blink variants of generated bindings, while the generated struct/union type is not. By changing StructTraits/UnionTraits to be specialized by the DataView type, users will be able to use the same StructTraits specialization in both variants.

BUG=632061
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/1764bb964000947012673f05dfcebfcbe77a6a63
Cr-Commit-Position: refs/heads/master@{#413931}

[yzshen1, 2016-08-17 22:49:55]

Description was changed from

==========
Mojo C++ bindings: change the first template parameter of StructTraits and
UnionTraits.

Previously the type is the auto-generated struct/union type. This CL changes it
to the corresponding DataView type.

BUG=632061
==========

to

==========
Mojo C++ bindings: change the first template parameter of StructTraits and
UnionTraits.

Previously the type is the auto-generated struct/union type. This CL changes it
to the corresponding DataView type.

BUG=632061
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yzshen1, 2016-08-17 22:49:56]

Description was changed from

==========
Mojo C++ bindings: change the first template parameter of StructTraits and
UnionTraits.

Previously the type is the auto-generated struct/union type. This CL changes it
to the corresponding DataView type.

BUG=632061
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Mojo C++ bindings: change the first template parameter of StructTraits and
UnionTraits.

Previously the type is the auto-generated struct/union type. This CL changes it
to the corresponding DataView type.

BUG=632061
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[yzshen1, 2016-08-17 22:50:04]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 22:50:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 22:53:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 22:53:02]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[yzshen1, 2016-08-22 20:37:31]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 20:38:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-08-22 20:44:16]

yzshen@chromium.org changed reviewers:
+ dcheng@chromium.org, lhchavez@chromium.org, rockot@chromium.org,
sky@chromium.org

[yzshen1, 2016-08-22 20:44:17]

Hi,

Please take a look! Thanks!

Luis: components/arc/*
Scott: ui/*
Daniel: security review
Ken: general Mojo review

[commit-bot: I haz the power, 2016-08-22 20:50:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 20:50:15]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Rockot(use gerrit already), 2016-08-22 20:59:26]

lgtm

[yzshen1, 2016-08-22 21:02:59]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 21:05:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Luis Héctor Chávez, 2016-08-22 21:07:35]

just confirming, this is expected to not change the protocol or serialization?

[yzshen1, 2016-08-22 21:10:23]

On 2016/08/22 21:07:35, Luis Héctor Chávez wrote:
> just confirming, this is expected to not change the protocol or serialization?

No. The CL just changes how to specialize StructTraits, the
protocol/serialization should be exactly the same.

[Luis Héctor Chávez, 2016-08-22 21:11:02]

lgtm then!

[commit-bot: I haz the power, 2016-08-22 23:19:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 23:19:04]

Dry run: This issue passed the CQ dry run.

[sky, 2016-08-22 23:24:27]

LGTM

[dcheng, 2016-08-23 22:18:50]

lgtm

[yzshen1, 2016-08-23 22:29:58]

Description was changed from

==========
Mojo C++ bindings: change the first template parameter of StructTraits and
UnionTraits.

Previously the type is the auto-generated struct/union type. This CL changes it
to the corresponding DataView type.

BUG=632061
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Mojo C++ bindings: change the first template parameter of StructTraits and
UnionTraits.

Previously the type is the auto-generated struct/union type. This CL changes it
to the corresponding DataView type.

The reason of doing this? The DataView type is shared by the chromium and blink
variants of generated bindings, while the generated struct/union type is not. By
changing StructTraits/UnionTraits to be specialized by the DataView type, users
will be able to use the same StructTraits specialization in both variants.


BUG=632061
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[yzshen1, 2016-08-23 22:41:04]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-08-23 22:41:05]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
lhchavez@chromium.org, sky@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2253293002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-23 22:42:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 01:44:30]

Description was changed from

==========
Mojo C++ bindings: change the first template parameter of StructTraits and
UnionTraits.

Previously the type is the auto-generated struct/union type. This CL changes it
to the corresponding DataView type.

The reason of doing this? The DataView type is shared by the chromium and blink
variants of generated bindings, while the generated struct/union type is not. By
changing StructTraits/UnionTraits to be specialized by the DataView type, users
will be able to use the same StructTraits specialization in both variants.


BUG=632061
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Mojo C++ bindings: change the first template parameter of StructTraits and
UnionTraits.

Previously the type is the auto-generated struct/union type. This CL changes it
to the corresponding DataView type.

The reason of doing this? The DataView type is shared by the chromium and blink
variants of generated bindings, while the generated struct/union type is not. By
changing StructTraits/UnionTraits to be specialized by the DataView type, users
will be able to use the same StructTraits specialization in both variants.


BUG=632061
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-08-24 01:44:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-24 01:46:09]

Description was changed from

==========
Mojo C++ bindings: change the first template parameter of StructTraits and
UnionTraits.

Previously the type is the auto-generated struct/union type. This CL changes it
to the corresponding DataView type.

The reason of doing this? The DataView type is shared by the chromium and blink
variants of generated bindings, while the generated struct/union type is not. By
changing StructTraits/UnionTraits to be specialized by the DataView type, users
will be able to use the same StructTraits specialization in both variants.


BUG=632061
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Mojo C++ bindings: change the first template parameter of StructTraits and
UnionTraits.

Previously the type is the auto-generated struct/union type. This CL changes it
to the corresponding DataView type.

The reason of doing this? The DataView type is shared by the chromium and blink
variants of generated bindings, while the generated struct/union type is not. By
changing StructTraits/UnionTraits to be specialized by the DataView type, users
will be able to use the same StructTraits specialization in both variants.

BUG=632061
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/1764bb964000947012673f05dfcebfcbe77a6a63
Cr-Commit-Position: refs/heads/master@{#413931}
==========

[commit-bot: I haz the power, 2016-08-24 01:46:11]

Patchset 4 (id:??) landed as
https://crrev.com/1764bb964000947012673f05dfcebfcbe77a6a63
Cr-Commit-Position: refs/heads/master@{#413931}