mojo/public/tools/bindings/generators/cpp_templates/union_traits_definition.tmpl - Issue 2259283003: Mojo C++ bindings: share DataView class between chromium and blink variants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/union_traits_definition.tmpl

Issue 2259283003: Mojo C++ bindings: share DataView class between chromium and blink variants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@92_change_traits_param

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/union_traits_declaration.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/union_traits_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/union_traits_definition.tmpl

similarity index 81%

rename from mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

rename to mojo/public/tools/bindings/generators/cpp_templates/union_traits_definition.tmpl

index 5394950b2dc5c8989e04f7fe24dbc79fc63cc155..cde3f95669369fad483f82f05dd8142acc45fef1 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/union_traits_definition.tmpl

@@ -19,10 +19,15 @@ bool UnionTraits<{{mojom_type}}::DataView, {{mojom_type}}Ptr>::Read(

if (!input.Read{{name|under_to_camel}}(result_acc.data()->{{name}}))

return false;

-{%- elif kind|is_any_handle_or_interface_kind %}

+{%- elif kind|is_any_handle_kind %}

auto result_{{name}} = input.Take{{name|under_to_camel}}();

result->set_{{name}}(std::move(result_{{name}}));

+{%- elif kind|is_any_interface_kind %}

+ auto result_{{name}} =

+ input.Take{{name|under_to_camel}}<typename std::remove_reference<decltype(result->get_{{name}}())>::type>();

+ result->set_{{name}}(std::move(result_{{name}}));

{%- elif kind|is_enum_kind %}

decltype(result->get_{{name}}()) result_{{name}};

if (!input.Read{{name|under_to_camel}}(&result_{{name}}))