mojo/public/tools/bindings/generators/mojom_js_generator.py - Issue 2259283003: Mojo C++ bindings: share DataView class between chromium and blink variants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_js_generator.py

Issue 2259283003: Mojo C++ bindings: share DataView class between chromium and blink variants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@92_change_traits_param

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/mojom_cpp_generator.py ('k') | mojo/public/tools/bindings/pylib/mojom/generate/module.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/mojom_js_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_js_generator.py b/mojo/public/tools/bindings/generators/mojom_js_generator.py

index e9a488388d660868d149c5c88571d55b19e4efc5..c79141771570099e27ce15bf41538fc5ed12dd5b 100644

--- a/mojo/public/tools/bindings/generators/mojom_js_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_js_generator.py

@@ -331,6 +331,9 @@ def IsHandleField(field):

def IsInterfaceField(field):

return mojom.IsInterfaceKind(field.kind)

+def IsInterfaceRequestField(field):

+ return mojom.IsInterfaceRequestKind(field.kind)

def IsUnionField(field):

return mojom.IsUnionKind(field.kind)

@@ -354,6 +357,7 @@ class Generator(generator.Generator):

"is_union_field": IsUnionField,

"is_handle_field": IsHandleField,

"is_interface_field": IsInterfaceField,

+ "is_interface_request_field": IsInterfaceRequestField,

"js_type": JavaScriptType,

"js_proxy_method_parameter_value": JavaScriptProxyMethodParameterValue,

"js_stub_method_parameter_value": JavaScriptStubMethodParameterValue,