mojo/public/cpp/bindings/lib/string_serialization.h - Issue 2259283003: Mojo C++ bindings: share DataView class between chromium and blink variants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/string_serialization.h

Issue 2259283003: Mojo C++ bindings: share DataView class between chromium and blink variants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@92_change_traits_param

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/cpp/bindings/lib/string_serialization.h

diff --git a/mojo/public/cpp/bindings/lib/string_serialization.h b/mojo/public/cpp/bindings/lib/string_serialization.h

index 0b62e06156bf99b16936fe854567e9c096601d8f..6e0c75857690af53b1a11dd7cdbe70c0b6fea6c5 100644

--- a/mojo/public/cpp/bindings/lib/string_serialization.h

+++ b/mojo/public/cpp/bindings/lib/string_serialization.h

@@ -11,14 +11,14 @@

#include "mojo/public/cpp/bindings/lib/array_internal.h"

#include "mojo/public/cpp/bindings/lib/serialization_forward.h"

#include "mojo/public/cpp/bindings/lib/serialization_util.h"

-#include "mojo/public/cpp/bindings/string.h"

+#include "mojo/public/cpp/bindings/string_data_view.h"

#include "mojo/public/cpp/bindings/string_traits.h"

namespace mojo {

namespace internal {

template <typename MaybeConstUserType>

-struct Serializer<String, MaybeConstUserType> {

+struct Serializer<StringDataView, MaybeConstUserType> {

using UserType = typename std::remove_const<MaybeConstUserType>::type;

using Traits = StringTraits<UserType>;

« no previous file with comments | « mojo/public/cpp/bindings/lib/serialization.h ('k') | mojo/public/cpp/bindings/map_data_view.h » ('j') | no next file with comments »