mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl - Issue 2259283003: Mojo C++ bindings: share DataView class between chromium and blink variants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

Issue 2259283003: Mojo C++ bindings: share DataView class between chromium and blink variants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@92_change_traits_param

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

index c59f317880d981a58a00df6e3d2d699d7a3e297e..fbf60dd9541a50ad0e8d30fc2aa369f36bf5ffde 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

@@ -148,8 +148,11 @@

{%- if kind|is_object_kind or kind|is_enum_kind %}

if (!{{input}}.Read{{name|under_to_camel}}(&{{output_field}}))

{{success}} = false;

-{%- elif kind|is_any_handle_or_interface_kind %}

+{%- elif kind|is_any_handle_kind %}

{{output_field}} = {{input}}.Take{{name|under_to_camel}}();

+{%- elif kind|is_any_interface_kind %}

+ {{output_field}} =

+ {{input}}.Take{{name|under_to_camel}}<decltype({{output_field}})>();

{%- else %}

{{output_field}} = {{input}}.{{name}}();

{%- endif %}