mojo/public/interfaces/bindings/tests/rect.mojom - Issue 2259283003: Mojo C++ bindings: share DataView class between chromium and blink variants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/interfaces/bindings/tests/rect.mojom

Issue 2259283003: Mojo C++ bindings: share DataView class between chromium and blink variants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@92_change_traits_param

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/wtf_types_unittest.cc ('k') | mojo/public/interfaces/bindings/tests/test_native_types.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/interfaces/bindings/tests/rect.mojom

diff --git a/mojo/public/interfaces/bindings/tests/rect.mojom b/mojo/public/interfaces/bindings/tests/rect.mojom

index 833c76bb2a45c8b7f8d32b3bec58648ea7b291e4..4ecc4d9660ce705ee937502925b80d68c5001826 100644

--- a/mojo/public/interfaces/bindings/tests/rect.mojom

+++ b/mojo/public/interfaces/bindings/tests/rect.mojom

@@ -12,11 +12,20 @@ struct Rect {

int32 height;

};

-// A copy of Rect that can be typemapped. Arrays of Rect are currently used,

-// which do not support typemapping.

+// A copy of Rect that is typemapped differently in the chromium and blink

+// variants.

struct TypemappedRect {

int32 x;

int32 y;

int32 width;

int32 height;

};

+// A copy of Rect that is typemapped to the same custom type in the chromium and

+// blink variants.

+struct SharedTypemappedRect {

+ int32 x;

+ int32 y;

+ int32 width;

+ int32 height;

+};