Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2988)

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl

Issue 2259283003: Mojo C++ bindings: share DataView class between chromium and blink variants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@92_change_traits_param
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl
diff --git a/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl
index edab4c256736a5043b34013961e76508de4e2c89..4383acbd8facb7d68151dd36ae89b38288165187 100644
--- a/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl
+++ b/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl
@@ -55,24 +55,6 @@ const {{constant.kind|cpp_pod_type}} {{constant.name}} = {{constant|constant_val
{%- endif %}
{%- endfor %}
-namespace {
-
-{#--- Interface parameter data view definitions #}
-{%- for interface in interfaces %}
-{%- for method in interface.methods %}
-{% set struct = method.param_struct %}
-{% include "struct_data_view_declaration.tmpl" %}
-{% include "struct_data_view_definition.tmpl" %}
-{%- if method.response_parameters != None %}
-{%- set struct = method.response_param_struct %}
-{% include "struct_data_view_declaration.tmpl" %}
-{% include "struct_data_view_definition.tmpl" %}
-{%- endif %}
-{%- endfor %}
-{%- endfor %}
-
-} // namespace
-
{#--- Struct Constants #}
{%- for struct in structs %}
{%- for constant in struct.constants %}
@@ -113,18 +95,17 @@ namespace mojo {
{#--- Struct Serialization Helpers -#}
{% for struct in structs %}
{%- if not struct|is_native_only_kind %}
-{% include "struct_serialization_definition.tmpl" %}
+{% include "struct_traits_definition.tmpl" %}
{%- endif %}
{%- endfor %}
{#--- Union Serialization Helpers #}
{%- for union in unions %}
-{%- include "union_serialization_definition.tmpl" %}
+{%- include "union_traits_definition.tmpl" %}
{%- endfor %}
} // namespace mojo
-
#if defined(__clang__)
#pragma clang diagnostic pop
#elif defined(_MSC_VER)

Powered by Google App Engine
This is Rietveld 408576698