mojo/public/tools/bindings/generators/cpp_templates/struct_traits_definition.tmpl - Issue 2259283003: Mojo C++ bindings: share DataView class between chromium and blink variants.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_traits_definition.tmpl

Issue 2259283003: Mojo C++ bindings: share DataView class between chromium and blink variants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@92_change_traits_param

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/struct_traits_declaration.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/union_data_view_declaration.tmpl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {%- import "struct_macros.tmpl" as struct_macros %}	1 {%- import "struct_macros.tmpl" as struct_macros %}

2 {%- set mojom_type = struct\|get_qualified_name_for_kind %}	2 {%- set mojom_type = struct\|get_qualified_name_for_kind %}

3	3

4 // static	4 // static

5 bool StructTraits<{{mojom_type}}::DataView, {{mojom_type}}Ptr>::Read(	5 bool StructTraits<{{mojom_type}}::DataView, {{mojom_type}}Ptr>::Read(

6 {{mojom_type}}::DataView input,	6 {{mojom_type}}::DataView input,

7 {{mojom_type}}Ptr* output) {	7 {{mojom_type}}Ptr* output) {

8 bool success = true;	8 bool success = true;

9 {{mojom_type}}Ptr result({{mojom_type}}::New());	9 {{mojom_type}}Ptr result({{mojom_type}}::New());

10 {{struct_macros.deserialize(struct, "input", "result->%s",	10 {{struct_macros.deserialize(struct, "input", "result->%s",

11 "success")\|indent(4)}}	11 "success")\|indent(4)}}

12 *output = std::move(result);	12 *output = std::move(result);

13 return success;	13 return success;

14 }	14 }

OLD	NEW