Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2567)

Unified Diff: mojo/public/cpp/bindings/lib/control_message_handler.cc

Issue 2259283003: Mojo C++ bindings: share DataView class between chromium and blink variants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@92_change_traits_param
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/lib/control_message_handler.cc
diff --git a/mojo/public/cpp/bindings/lib/control_message_handler.cc b/mojo/public/cpp/bindings/lib/control_message_handler.cc
index 9f44e88f4f4c06d623d25b2f0ce78841b980e384..75388d105e376ee73c65ef25759cb179b9fed7dc 100644
--- a/mojo/public/cpp/bindings/lib/control_message_handler.cc
+++ b/mojo/public/cpp/bindings/lib/control_message_handler.cc
@@ -56,13 +56,13 @@ bool ControlMessageHandler::Run(Message* message,
response_params_ptr->query_version_result = QueryVersionResult::New();
response_params_ptr->query_version_result->version = interface_version_;
- size_t size = PrepareToSerialize<RunResponseMessageParamsPtr>(
+ size_t size = PrepareToSerialize<RunResponseMessageParamsDataView>(
response_params_ptr, &context_);
ResponseMessageBuilder builder(kRunMessageId, size, message->request_id());
RunResponseMessageParams_Data* response_params = nullptr;
- Serialize<RunResponseMessageParamsPtr>(response_params_ptr, builder.buffer(),
- &response_params, &context_);
+ Serialize<RunResponseMessageParamsDataView>(
+ response_params_ptr, builder.buffer(), &response_params, &context_);
bool ok = responder->Accept(builder.message());
ALLOW_UNUSED_LOCAL(ok);
delete responder;
@@ -75,7 +75,8 @@ bool ControlMessageHandler::RunOrClosePipe(Message* message) {
reinterpret_cast<RunOrClosePipeMessageParams_Data*>(
message->mutable_payload());
RunOrClosePipeMessageParamsPtr params_ptr;
- Deserialize<RunOrClosePipeMessageParamsPtr>(params, &params_ptr, &context_);
+ Deserialize<RunOrClosePipeMessageParamsDataView>(params, &params_ptr,
+ &context_);
return interface_version_ >= params_ptr->require_version->version;
}
« no previous file with comments | « mojo/public/cpp/bindings/lib/bindings_internal.h ('k') | mojo/public/cpp/bindings/lib/control_message_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698