Re-write many calls to WrapUnique() with MakeUnique()

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812
Committed: https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3
Cr-Commit-Position: refs/heads/master@{#413954}

[Adam Rice, 2016-08-18 10:19:59]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 10:20:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 11:27:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 11:27:04]

Dry run: This issue passed the CQ dry run.

[Adam Rice, 2016-08-19 07:40:36]

ricea@chromium.org changed reviewers:
+ zelidrag@chromium.org

[achuithb, 2016-08-20 00:38:19]

achuith@chromium.org changed reviewers:
+ achuith@chromium.org, xiaoyinh@chromium.org

[achuithb, 2016-08-20 00:38:19]

I don't think Zel will have time to look at this, Xiaoyin - do you have time to
review this?

[xiaoyinh(OOO Sep 11-29), 2016-08-22 17:26:07]

LGTM.

You still need owner's approval though. Thanks!

[xiaoyinh(OOO Sep 11-29), 2016-08-22 17:26:28]

On 2016/08/20 00:38:19, achuithb wrote:
> I don't think Zel will have time to look at this, Xiaoyin - do you have time
to
> review this?

Done.

[achuithb, 2016-08-22 17:45:40]

lgtm

[Adam Rice, 2016-08-24 01:45:34]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2016-08-24 01:46:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 02:45:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-24 02:46:39]

Description was changed from

==========
Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812
==========

to

==========
Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Committed: https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3
Cr-Commit-Position: refs/heads/master@{#413954}
==========

[commit-bot: I haz the power, 2016-08-24 02:46:41]

Patchset 1 (id:??) landed as
https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3
Cr-Commit-Position: refs/heads/master@{#413954}