Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc

Issue 2257103002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/policy/cloud_external_data_manager_base.h" 5 #include "chrome/browser/chromeos/policy/cloud_external_data_manager_base.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 152
153 void CloudExternalDataManagerBaseTest::SetUp() { 153 void CloudExternalDataManagerBaseTest::SetUp() {
154 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); 154 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
155 resource_cache_.reset( 155 resource_cache_.reset(
156 new ResourceCache(temp_dir_.path(), message_loop_.task_runner())); 156 new ResourceCache(temp_dir_.path(), message_loop_.task_runner()));
157 SetUpExternalDataManager(); 157 SetUpExternalDataManager();
158 158
159 // Set |kStringPolicy| to a string value. 159 // Set |kStringPolicy| to a string value.
160 cloud_policy_store_.policy_map_.Set( 160 cloud_policy_store_.policy_map_.Set(
161 kStringPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, 161 kStringPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
162 POLICY_SOURCE_CLOUD, 162 POLICY_SOURCE_CLOUD, base::MakeUnique<base::StringValue>(std::string()),
163 base::WrapUnique(new base::StringValue(std::string())), nullptr); 163 nullptr);
164 // Make |k10BytePolicy| reference 10 bytes of external data. 164 // Make |k10BytePolicy| reference 10 bytes of external data.
165 SetExternalDataReference( 165 SetExternalDataReference(
166 k10BytePolicy, 166 k10BytePolicy,
167 ConstructMetadata(k10BytePolicyURL, 167 ConstructMetadata(k10BytePolicyURL,
168 crypto::SHA256HashString(k10ByteData))); 168 crypto::SHA256HashString(k10ByteData)));
169 // Make |k20BytePolicy| reference 20 bytes of external data. 169 // Make |k20BytePolicy| reference 20 bytes of external data.
170 SetExternalDataReference( 170 SetExternalDataReference(
171 k20BytePolicy, 171 k20BytePolicy,
172 ConstructMetadata(k20BytePolicyURL, 172 ConstructMetadata(k20BytePolicyURL,
173 crypto::SHA256HashString(k20ByteData))); 173 crypto::SHA256HashString(k20ByteData)));
(...skipping 11 matching lines...) Expand all
185 external_data_manager_.reset(); 185 external_data_manager_.reset();
186 base::RunLoop().RunUntilIdle(); 186 base::RunLoop().RunUntilIdle();
187 ResetCallbackData(); 187 ResetCallbackData();
188 } 188 }
189 189
190 void CloudExternalDataManagerBaseTest::SetUpExternalDataManager() { 190 void CloudExternalDataManagerBaseTest::SetUpExternalDataManager() {
191 external_data_manager_.reset(new CloudExternalDataManagerBase( 191 external_data_manager_.reset(new CloudExternalDataManagerBase(
192 policy_details_.GetCallback(), message_loop_.task_runner(), 192 policy_details_.GetCallback(), message_loop_.task_runner(),
193 message_loop_.task_runner())); 193 message_loop_.task_runner()));
194 external_data_manager_->SetExternalDataStore( 194 external_data_manager_->SetExternalDataStore(
195 base::WrapUnique(new CloudExternalDataStore( 195 base::MakeUnique<CloudExternalDataStore>(
196 kCacheKey, message_loop_.task_runner(), resource_cache_.get()))); 196 kCacheKey, message_loop_.task_runner(), resource_cache_.get()));
197 external_data_manager_->SetPolicyStore(&cloud_policy_store_); 197 external_data_manager_->SetPolicyStore(&cloud_policy_store_);
198 } 198 }
199 199
200 std::unique_ptr<base::DictionaryValue> 200 std::unique_ptr<base::DictionaryValue>
201 CloudExternalDataManagerBaseTest::ConstructMetadata(const std::string& url, 201 CloudExternalDataManagerBaseTest::ConstructMetadata(const std::string& url,
202 const std::string& hash) { 202 const std::string& hash) {
203 std::unique_ptr<base::DictionaryValue> metadata(new base::DictionaryValue); 203 std::unique_ptr<base::DictionaryValue> metadata(new base::DictionaryValue);
204 metadata->SetStringWithoutPathExpansion("url", url); 204 metadata->SetStringWithoutPathExpansion("url", url);
205 metadata->SetStringWithoutPathExpansion("hash", base::HexEncode(hash.c_str(), 205 metadata->SetStringWithoutPathExpansion("hash", base::HexEncode(hash.c_str(),
206 hash.size())); 206 hash.size()));
207 return metadata; 207 return metadata;
208 } 208 }
209 209
210 void CloudExternalDataManagerBaseTest::SetExternalDataReference( 210 void CloudExternalDataManagerBaseTest::SetExternalDataReference(
211 const std::string& policy, 211 const std::string& policy,
212 std::unique_ptr<base::DictionaryValue> metadata) { 212 std::unique_ptr<base::DictionaryValue> metadata) {
213 cloud_policy_store_.policy_map_.Set( 213 cloud_policy_store_.policy_map_.Set(
214 policy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, 214 policy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
215 std::move(metadata), 215 std::move(metadata),
216 base::WrapUnique(new ExternalDataFetcher( 216 base::MakeUnique<ExternalDataFetcher>(
217 external_data_manager_->weak_factory_.GetWeakPtr(), policy))); 217 external_data_manager_->weak_factory_.GetWeakPtr(), policy));
218 } 218 }
219 219
220 ExternalDataFetcher::FetchCallback 220 ExternalDataFetcher::FetchCallback
221 CloudExternalDataManagerBaseTest::ConstructFetchCallback(int id) { 221 CloudExternalDataManagerBaseTest::ConstructFetchCallback(int id) {
222 return base::Bind(&CloudExternalDataManagerBaseTest::OnFetchDone, 222 return base::Bind(&CloudExternalDataManagerBaseTest::OnFetchDone,
223 base::Unretained(this), 223 base::Unretained(this),
224 id); 224 id);
225 } 225 }
226 226
227 void CloudExternalDataManagerBaseTest::ResetCallbackData() { 227 void CloudExternalDataManagerBaseTest::ResetCallbackData() {
(...skipping 531 matching lines...) Expand 10 before | Expand all | Expand 10 after
759 crypto::SHA256HashString(k10ByteData))); 759 crypto::SHA256HashString(k10ByteData)));
760 cloud_policy_store_.NotifyStoreLoaded(); 760 cloud_policy_store_.NotifyStoreLoaded();
761 base::RunLoop().RunUntilIdle(); 761 base::RunLoop().RunUntilIdle();
762 EXPECT_EQ(1u, callback_data_.size()); 762 EXPECT_EQ(1u, callback_data_.size());
763 ASSERT_TRUE(callback_data_[1]); 763 ASSERT_TRUE(callback_data_[1]);
764 EXPECT_EQ(k10ByteData, *callback_data_[1]); 764 EXPECT_EQ(k10ByteData, *callback_data_[1]);
765 ResetCallbackData(); 765 ResetCallbackData();
766 } 766 }
767 767
768 } // namespace policy 768 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698