Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc

Issue 2257103002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory> 5 #include <memory>
6 #include <string> 6 #include <string>
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 137
138 TEST_F(ArcPolicyBridgeTest, EmptyPolicyTest) { 138 TEST_F(ArcPolicyBridgeTest, EmptyPolicyTest) {
139 // No policy is set, result should be empty. 139 // No policy is set, result should be empty.
140 policy_bridge()->GetPolicies(PolicyStringCallback("{}")); 140 policy_bridge()->GetPolicies(PolicyStringCallback("{}"));
141 } 141 }
142 142
143 TEST_F(ArcPolicyBridgeTest, ArcPolicyTest) { 143 TEST_F(ArcPolicyBridgeTest, ArcPolicyTest) {
144 policy_map().Set( 144 policy_map().Set(
145 policy::key::kArcPolicy, policy::POLICY_LEVEL_MANDATORY, 145 policy::key::kArcPolicy, policy::POLICY_LEVEL_MANDATORY,
146 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD, 146 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
147 base::WrapUnique(new base::StringValue( 147 base::MakeUnique<base::StringValue>(
148 "{\"applications\":" 148 "{\"applications\":"
149 "[{\"packageName\":\"com.google.android.apps.youtube.kids\"," 149 "[{\"packageName\":\"com.google.android.apps.youtube.kids\","
150 "\"installType\":\"REQUIRED\"," 150 "\"installType\":\"REQUIRED\","
151 "\"lockTaskAllowed\":false," 151 "\"lockTaskAllowed\":false,"
152 "\"permissionGrants\":[]" 152 "\"permissionGrants\":[]"
153 "}]," 153 "}],"
154 "\"defaultPermissionPolicy\":\"GRANT\"" 154 "\"defaultPermissionPolicy\":\"GRANT\""
155 "}")), 155 "}"),
156 nullptr); 156 nullptr);
157 policy_bridge()->GetPolicies(PolicyStringCallback( 157 policy_bridge()->GetPolicies(PolicyStringCallback(
158 "{\"applications\":" 158 "{\"applications\":"
159 "[{\"installType\":\"REQUIRED\"," 159 "[{\"installType\":\"REQUIRED\","
160 "\"lockTaskAllowed\":false," 160 "\"lockTaskAllowed\":false,"
161 "\"packageName\":\"com.google.android.apps.youtube.kids\"," 161 "\"packageName\":\"com.google.android.apps.youtube.kids\","
162 "\"permissionGrants\":[]" 162 "\"permissionGrants\":[]"
163 "}]," 163 "}],"
164 "\"defaultPermissionPolicy\":\"GRANT\"" 164 "\"defaultPermissionPolicy\":\"GRANT\""
165 "}")); 165 "}"));
166 } 166 }
167 167
168 TEST_F(ArcPolicyBridgeTest, HompageLocationTest) { 168 TEST_F(ArcPolicyBridgeTest, HompageLocationTest) {
169 // This policy will not be passed on, result should be empty. 169 // This policy will not be passed on, result should be empty.
170 policy_map().Set( 170 policy_map().Set(
171 policy::key::kHomepageLocation, policy::POLICY_LEVEL_MANDATORY, 171 policy::key::kHomepageLocation, policy::POLICY_LEVEL_MANDATORY,
172 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD, 172 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
173 base::WrapUnique(new base::StringValue("http://chromium.org")), nullptr); 173 base::MakeUnique<base::StringValue>("http://chromium.org"), nullptr);
174 policy_bridge()->GetPolicies(PolicyStringCallback("{}")); 174 policy_bridge()->GetPolicies(PolicyStringCallback("{}"));
175 } 175 }
176 176
177 TEST_F(ArcPolicyBridgeTest, DisableScreenshotsTest) { 177 TEST_F(ArcPolicyBridgeTest, DisableScreenshotsTest) {
178 policy_map().Set(policy::key::kDisableScreenshots, 178 policy_map().Set(policy::key::kDisableScreenshots,
179 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER, 179 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
180 policy::POLICY_SOURCE_CLOUD, 180 policy::POLICY_SOURCE_CLOUD,
181 base::WrapUnique(new base::FundamentalValue(true)), nullptr); 181 base::MakeUnique<base::FundamentalValue>(true), nullptr);
182 policy_bridge()->GetPolicies( 182 policy_bridge()->GetPolicies(
183 PolicyStringCallback("{\"screenCaptureDisabled\":true}")); 183 PolicyStringCallback("{\"screenCaptureDisabled\":true}"));
184 } 184 }
185 185
186 TEST_F(ArcPolicyBridgeTest, VideoCaptureAllowedTest) { 186 TEST_F(ArcPolicyBridgeTest, VideoCaptureAllowedTest) {
187 policy_map().Set( 187 policy_map().Set(policy::key::kVideoCaptureAllowed,
188 policy::key::kVideoCaptureAllowed, policy::POLICY_LEVEL_MANDATORY, 188 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
189 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD, 189 policy::POLICY_SOURCE_CLOUD,
190 base::WrapUnique(new base::FundamentalValue(false)), nullptr); 190 base::MakeUnique<base::FundamentalValue>(false), nullptr);
191 policy_bridge()->GetPolicies( 191 policy_bridge()->GetPolicies(
192 PolicyStringCallback("{\"cameraDisabled\":true}")); 192 PolicyStringCallback("{\"cameraDisabled\":true}"));
193 } 193 }
194 194
195 TEST_F(ArcPolicyBridgeTest, AudioCaptureAllowedTest) { 195 TEST_F(ArcPolicyBridgeTest, AudioCaptureAllowedTest) {
196 policy_map().Set( 196 policy_map().Set(policy::key::kAudioCaptureAllowed,
197 policy::key::kAudioCaptureAllowed, policy::POLICY_LEVEL_MANDATORY, 197 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
198 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD, 198 policy::POLICY_SOURCE_CLOUD,
199 base::WrapUnique(new base::FundamentalValue(false)), nullptr); 199 base::MakeUnique<base::FundamentalValue>(false), nullptr);
200 policy_bridge()->GetPolicies( 200 policy_bridge()->GetPolicies(
201 PolicyStringCallback("{\"unmuteMicrophoneDisabled\":true}")); 201 PolicyStringCallback("{\"unmuteMicrophoneDisabled\":true}"));
202 } 202 }
203 203
204 TEST_F(ArcPolicyBridgeTest, DefaultGeolocationSettingTest) { 204 TEST_F(ArcPolicyBridgeTest, DefaultGeolocationSettingTest) {
205 policy_map().Set(policy::key::kDefaultGeolocationSetting, 205 policy_map().Set(policy::key::kDefaultGeolocationSetting,
206 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER, 206 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
207 policy::POLICY_SOURCE_CLOUD, 207 policy::POLICY_SOURCE_CLOUD,
208 base::WrapUnique(new base::FundamentalValue(1)), nullptr); 208 base::MakeUnique<base::FundamentalValue>(1), nullptr);
209 policy_bridge()->GetPolicies( 209 policy_bridge()->GetPolicies(
210 PolicyStringCallback("{\"shareLocationDisabled\":false}")); 210 PolicyStringCallback("{\"shareLocationDisabled\":false}"));
211 policy_map().Set(policy::key::kDefaultGeolocationSetting, 211 policy_map().Set(policy::key::kDefaultGeolocationSetting,
212 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER, 212 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
213 policy::POLICY_SOURCE_CLOUD, 213 policy::POLICY_SOURCE_CLOUD,
214 base::WrapUnique(new base::FundamentalValue(2)), nullptr); 214 base::MakeUnique<base::FundamentalValue>(2), nullptr);
215 policy_bridge()->GetPolicies( 215 policy_bridge()->GetPolicies(
216 PolicyStringCallback("{\"shareLocationDisabled\":true}")); 216 PolicyStringCallback("{\"shareLocationDisabled\":true}"));
217 policy_map().Set(policy::key::kDefaultGeolocationSetting, 217 policy_map().Set(policy::key::kDefaultGeolocationSetting,
218 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER, 218 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
219 policy::POLICY_SOURCE_CLOUD, 219 policy::POLICY_SOURCE_CLOUD,
220 base::WrapUnique(new base::FundamentalValue(3)), nullptr); 220 base::MakeUnique<base::FundamentalValue>(3), nullptr);
221 policy_bridge()->GetPolicies( 221 policy_bridge()->GetPolicies(
222 PolicyStringCallback("{\"shareLocationDisabled\":false}")); 222 PolicyStringCallback("{\"shareLocationDisabled\":false}"));
223 } 223 }
224 224
225 TEST_F(ArcPolicyBridgeTest, ExternalStorageDisabledTest) { 225 TEST_F(ArcPolicyBridgeTest, ExternalStorageDisabledTest) {
226 policy_map().Set(policy::key::kExternalStorageDisabled, 226 policy_map().Set(policy::key::kExternalStorageDisabled,
227 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER, 227 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
228 policy::POLICY_SOURCE_CLOUD, 228 policy::POLICY_SOURCE_CLOUD,
229 base::WrapUnique(new base::FundamentalValue(true)), nullptr); 229 base::MakeUnique<base::FundamentalValue>(true), nullptr);
230 policy_bridge()->GetPolicies( 230 policy_bridge()->GetPolicies(
231 PolicyStringCallback("{\"mountPhysicalMediaDisabled\":true}")); 231 PolicyStringCallback("{\"mountPhysicalMediaDisabled\":true}"));
232 } 232 }
233 233
234 TEST_F(ArcPolicyBridgeTest, URLBlacklistTest) { 234 TEST_F(ArcPolicyBridgeTest, URLBlacklistTest) {
235 base::ListValue blacklist; 235 base::ListValue blacklist;
236 blacklist.Append(new base::StringValue("www.blacklist1.com")); 236 blacklist.Append(new base::StringValue("www.blacklist1.com"));
237 blacklist.Append(new base::StringValue("www.blacklist2.com")); 237 blacklist.Append(new base::StringValue("www.blacklist2.com"));
238 policy_map().Set(policy::key::kURLBlacklist, policy::POLICY_LEVEL_MANDATORY, 238 policy_map().Set(policy::key::kURLBlacklist, policy::POLICY_LEVEL_MANDATORY,
239 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD, 239 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
(...skipping 19 matching lines...) Expand all
259 "[\"www.whitelist1.com\"," 259 "[\"www.whitelist1.com\","
260 "\"www.whitelist2.com\"" 260 "\"www.whitelist2.com\""
261 "]}}")); 261 "]}}"));
262 } 262 }
263 263
264 TEST_F(ArcPolicyBridgeTest, CaCertificateTest) { 264 TEST_F(ArcPolicyBridgeTest, CaCertificateTest) {
265 // Enable CA certificates sync. 265 // Enable CA certificates sync.
266 policy_map().Set( 266 policy_map().Set(
267 policy::key::kArcCertificatesSyncMode, policy::POLICY_LEVEL_MANDATORY, 267 policy::key::kArcCertificatesSyncMode, policy::POLICY_LEVEL_MANDATORY,
268 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD, 268 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
269 base::WrapUnique( 269 base::MakeUnique<base::FundamentalValue>(ArcCertsSyncMode::COPY_CA_CERTS),
270 new base::FundamentalValue(ArcCertsSyncMode::COPY_CA_CERTS)),
271 nullptr); 270 nullptr);
272 policy_map().Set(policy::key::kOpenNetworkConfiguration, 271 policy_map().Set(policy::key::kOpenNetworkConfiguration,
273 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER, 272 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
274 policy::POLICY_SOURCE_CLOUD, 273 policy::POLICY_SOURCE_CLOUD,
275 base::WrapUnique(new base::StringValue(kFakeONC)), nullptr); 274 base::MakeUnique<base::StringValue>(kFakeONC), nullptr);
276 policy_bridge()->GetPolicies(PolicyStringCallback( 275 policy_bridge()->GetPolicies(PolicyStringCallback(
277 "{\"caCerts\":" 276 "{\"caCerts\":"
278 "[{\"X509\":\"TWFuIGlzIGRpc3Rpbmd1aXNoZWQsIG5vdCBvbmx5IGJ5IGhpcyByZWFzb24" 277 "[{\"X509\":\"TWFuIGlzIGRpc3Rpbmd1aXNoZWQsIG5vdCBvbmx5IGJ5IGhpcyByZWFzb24"
279 "sIGJ1dCBieSB0aGlzIHNpbmd1bGFyIHBhc3Npb24gZnJvbSBvdGhlciBhbmltYWxzLCB3aGl" 278 "sIGJ1dCBieSB0aGlzIHNpbmd1bGFyIHBhc3Npb24gZnJvbSBvdGhlciBhbmltYWxzLCB3aGl"
280 "jaCBpcyBhIGx1c3Qgb2YgdGhlIG1pbmQsIHRoYXQgYnkgYSBwZXJzZXZlcmFuY2Ugb2YgZGV" 279 "jaCBpcyBhIGx1c3Qgb2YgdGhlIG1pbmQsIHRoYXQgYnkgYSBwZXJzZXZlcmFuY2Ugb2YgZGV"
281 "saWdodCBpbiB0aGUgY29udGludWVkIGFuZCBpbmRlZmF0aWdhYmxlIGdlbmVyYXRpb24gb2Y" 280 "saWdodCBpbiB0aGUgY29udGludWVkIGFuZCBpbmRlZmF0aWdhYmxlIGdlbmVyYXRpb24gb2Y"
282 "ga25vd2xlZGdlLCBleGNlZWRzIHRoZSBzaG9ydCB2ZWhlbWVuY2Ugb2YgYW55IGNhcm5hbCB" 281 "ga25vd2xlZGdlLCBleGNlZWRzIHRoZSBzaG9ydCB2ZWhlbWVuY2Ugb2YgYW55IGNhcm5hbCB"
283 "wbGVhc3VyZS4=\"}" 282 "wbGVhc3VyZS4=\"}"
284 "]}")); 283 "]}"));
285 284
286 // Disable CA certificates sync. 285 // Disable CA certificates sync.
287 policy_map().Set( 286 policy_map().Set(
288 policy::key::kArcCertificatesSyncMode, policy::POLICY_LEVEL_MANDATORY, 287 policy::key::kArcCertificatesSyncMode, policy::POLICY_LEVEL_MANDATORY,
289 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD, 288 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
290 base::WrapUnique( 289 base::MakeUnique<base::FundamentalValue>(ArcCertsSyncMode::SYNC_DISABLED),
291 new base::FundamentalValue(ArcCertsSyncMode::SYNC_DISABLED)),
292 nullptr); 290 nullptr);
293 policy_bridge()->GetPolicies(PolicyStringCallback("{}")); 291 policy_bridge()->GetPolicies(PolicyStringCallback("{}"));
294 } 292 }
295 293
296 TEST_F(ArcPolicyBridgeTest, DeveloperToolsDisabledTest) { 294 TEST_F(ArcPolicyBridgeTest, DeveloperToolsDisabledTest) {
297 policy_map().Set(policy::key::kDeveloperToolsDisabled, 295 policy_map().Set(policy::key::kDeveloperToolsDisabled,
298 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER, 296 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
299 policy::POLICY_SOURCE_CLOUD, 297 policy::POLICY_SOURCE_CLOUD,
300 base::WrapUnique(new base::FundamentalValue(true)), nullptr); 298 base::MakeUnique<base::FundamentalValue>(true), nullptr);
301 policy_bridge()->GetPolicies( 299 policy_bridge()->GetPolicies(
302 PolicyStringCallback("{\"debuggingFeaturesDisabled\":true}")); 300 PolicyStringCallback("{\"debuggingFeaturesDisabled\":true}"));
303 } 301 }
304 302
305 TEST_F(ArcPolicyBridgeTest, MultiplePoliciesTest) { 303 TEST_F(ArcPolicyBridgeTest, MultiplePoliciesTest) {
306 policy_map().Set( 304 policy_map().Set(
307 policy::key::kArcPolicy, policy::POLICY_LEVEL_MANDATORY, 305 policy::key::kArcPolicy, policy::POLICY_LEVEL_MANDATORY,
308 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD, 306 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
309 base::WrapUnique(new base::StringValue( 307 base::MakeUnique<base::StringValue>(
310 "{\"applications\":" 308 "{\"applications\":"
311 "[{\"packageName\":\"com.google.android.apps.youtube.kids\"," 309 "[{\"packageName\":\"com.google.android.apps.youtube.kids\","
312 "\"installType\":\"REQUIRED\"," 310 "\"installType\":\"REQUIRED\","
313 "\"lockTaskAllowed\":false," 311 "\"lockTaskAllowed\":false,"
314 "\"permissionGrants\":[]" 312 "\"permissionGrants\":[]"
315 "}]," 313 "}],"
316 "\"defaultPermissionPolicy\":\"GRANT\"}")), 314 "\"defaultPermissionPolicy\":\"GRANT\"}"),
317 nullptr); 315 nullptr);
318 policy_map().Set( 316 policy_map().Set(
319 policy::key::kHomepageLocation, policy::POLICY_LEVEL_MANDATORY, 317 policy::key::kHomepageLocation, policy::POLICY_LEVEL_MANDATORY,
320 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD, 318 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
321 base::WrapUnique(new base::StringValue("http://chromium.org")), nullptr); 319 base::MakeUnique<base::StringValue>("http://chromium.org"), nullptr);
322 policy_map().Set( 320 policy_map().Set(policy::key::kVideoCaptureAllowed,
323 policy::key::kVideoCaptureAllowed, policy::POLICY_LEVEL_MANDATORY, 321 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
324 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD, 322 policy::POLICY_SOURCE_CLOUD,
325 base::WrapUnique(new base::FundamentalValue(false)), nullptr); 323 base::MakeUnique<base::FundamentalValue>(false), nullptr);
326 policy_bridge()->GetPolicies(PolicyStringCallback( 324 policy_bridge()->GetPolicies(PolicyStringCallback(
327 "{\"applications\":" 325 "{\"applications\":"
328 "[{\"installType\":\"REQUIRED\"," 326 "[{\"installType\":\"REQUIRED\","
329 "\"lockTaskAllowed\":false," 327 "\"lockTaskAllowed\":false,"
330 "\"packageName\":\"com.google.android.apps.youtube.kids\"," 328 "\"packageName\":\"com.google.android.apps.youtube.kids\","
331 "\"permissionGrants\":[]" 329 "\"permissionGrants\":[]"
332 "}]," 330 "}],"
333 "\"cameraDisabled\":true," 331 "\"cameraDisabled\":true,"
334 "\"defaultPermissionPolicy\":\"GRANT\"" 332 "\"defaultPermissionPolicy\":\"GRANT\""
335 "}")); 333 "}"));
336 } 334 }
337 335
338 // This and the following test send the policies through a mojo connection 336 // This and the following test send the policies through a mojo connection
339 // between a PolicyInstance and the PolicyBridge. 337 // between a PolicyInstance and the PolicyBridge.
340 TEST_F(ArcPolicyBridgeTest, PolicyInstanceUnmanagedTest) { 338 TEST_F(ArcPolicyBridgeTest, PolicyInstanceUnmanagedTest) {
341 policy_bridge()->OverrideIsManagedForTesting(false); 339 policy_bridge()->OverrideIsManagedForTesting(false);
342 policy_instance()->CallGetPolicies(PolicyStringCallback("")); 340 policy_instance()->CallGetPolicies(PolicyStringCallback(""));
343 } 341 }
344 342
345 TEST_F(ArcPolicyBridgeTest, PolicyInstanceManagedTest) { 343 TEST_F(ArcPolicyBridgeTest, PolicyInstanceManagedTest) {
346 policy_instance()->CallGetPolicies(PolicyStringCallback("{}")); 344 policy_instance()->CallGetPolicies(PolicyStringCallback("{}"));
347 } 345 }
348 346
349 } // namespace arc 347 } // namespace arc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698