chrome/browser/chromeos/net/proxy_config_handler.cc - Issue 2257103002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/proxy_config_handler.cc

Issue 2257103002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc ('k') | chrome/browser/chromeos/platform_keys/key_permissions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/net/proxy_config_handler.cc

diff --git a/chrome/browser/chromeos/net/proxy_config_handler.cc b/chrome/browser/chromeos/net/proxy_config_handler.cc

index 979c6cc864bb2bd7d8f1bae37484e70a9d0b56e5..e2ad362c6f7a6ebd8e7bf369dfaadf57588766e1 100644

--- a/chrome/browser/chromeos/net/proxy_config_handler.cc

+++ b/chrome/browser/chromeos/net/proxy_config_handler.cc

@@ -61,7 +61,7 @@ std::unique_ptr<ProxyConfigDictionary> GetProxyConfigForNetwork(

std::unique_ptr<base::DictionaryValue> proxy_dict =

onc::ConvertOncProxySettingsToProxyConfig(*proxy_policy);

- return base::WrapUnique(new ProxyConfigDictionary(proxy_dict.get()));

+ return base::MakeUnique<ProxyConfigDictionary>(proxy_dict.get());

}

if (network.profile_path().empty())

@@ -90,7 +90,7 @@ std::unique_ptr<ProxyConfigDictionary> GetProxyConfigForNetwork(

const base::DictionaryValue& value = network.proxy_config();

if (value.empty())

return std::unique_ptr<ProxyConfigDictionary>();

- return base::WrapUnique(new ProxyConfigDictionary(&value));

+ return base::MakeUnique<ProxyConfigDictionary>(&value);

}

void SetProxyConfigForNetwork(const ProxyConfigDictionary& proxy_config,