Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Side by Side Diff: chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc

Issue 2257103002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.h" 5 #include "chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 391 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 void UserImageManagerImpl::Job::UpdateUser( 402 void UserImageManagerImpl::Job::UpdateUser(
403 std::unique_ptr<user_manager::UserImage> user_image) { 403 std::unique_ptr<user_manager::UserImage> user_image) {
404 user_manager::User* user = parent_->GetUserAndModify(); 404 user_manager::User* user = parent_->GetUserAndModify();
405 if (!user) 405 if (!user)
406 return; 406 return;
407 407
408 if (!user_image->image().isNull()) { 408 if (!user_image->image().isNull()) {
409 user->SetImage(std::move(user_image), image_index_); 409 user->SetImage(std::move(user_image), image_index_);
410 } else { 410 } else {
411 user->SetStubImage( 411 user->SetStubImage(
412 base::WrapUnique(new user_manager::UserImage( 412 base::MakeUnique<user_manager::UserImage>(
413 *ResourceBundle::GetSharedInstance().GetImageSkiaNamed( 413 *ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
414 IDR_PROFILE_PICTURE_LOADING))), 414 IDR_PROFILE_PICTURE_LOADING)),
415 image_index_, false); 415 image_index_, false);
416 } 416 }
417 user->SetImageURL(image_url_); 417 user->SetImageURL(image_url_);
418 418
419 parent_->OnJobChangedUserImage(); 419 parent_->OnJobChangedUserImage();
420 } 420 }
421 421
422 void UserImageManagerImpl::Job::UpdateUserAndSaveImage( 422 void UserImageManagerImpl::Job::UpdateUserAndSaveImage(
423 std::unique_ptr<user_manager::UserImage> user_image) { 423 std::unique_ptr<user_manager::UserImage> user_image) {
424 // TODO(crbug.com/593251): Remove the data copy. 424 // TODO(crbug.com/593251): Remove the data copy.
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 535
536 if (!image_properties) { 536 if (!image_properties) {
537 SetInitialUserImage(); 537 SetInitialUserImage();
538 return; 538 return;
539 } 539 }
540 540
541 int image_index = user_manager::User::USER_IMAGE_INVALID; 541 int image_index = user_manager::User::USER_IMAGE_INVALID;
542 image_properties->GetInteger(kImageIndexNodeName, &image_index); 542 image_properties->GetInteger(kImageIndexNodeName, &image_index);
543 if (image_index >= 0 && 543 if (image_index >= 0 &&
544 image_index < default_user_image::kDefaultImagesCount) { 544 image_index < default_user_image::kDefaultImagesCount) {
545 user->SetImage(base::WrapUnique(new user_manager::UserImage( 545 user->SetImage(base::MakeUnique<user_manager::UserImage>(
546 default_user_image::GetDefaultImage(image_index))), 546 default_user_image::GetDefaultImage(image_index)),
547 image_index); 547 image_index);
548 return; 548 return;
549 } 549 }
550 550
551 if (image_index != user_manager::User::USER_IMAGE_EXTERNAL && 551 if (image_index != user_manager::User::USER_IMAGE_EXTERNAL &&
552 image_index != user_manager::User::USER_IMAGE_PROFILE) { 552 image_index != user_manager::User::USER_IMAGE_PROFILE) {
553 NOTREACHED(); 553 NOTREACHED();
554 return; 554 return;
555 } 555 }
556 556
557 std::string image_url_string; 557 std::string image_url_string;
558 image_properties->GetString(kImageURLNodeName, &image_url_string); 558 image_properties->GetString(kImageURLNodeName, &image_url_string);
559 GURL image_url(image_url_string); 559 GURL image_url(image_url_string);
560 std::string image_path; 560 std::string image_path;
561 image_properties->GetString(kImagePathNodeName, &image_path); 561 image_properties->GetString(kImagePathNodeName, &image_path);
562 562
563 user->SetImageURL(image_url); 563 user->SetImageURL(image_url);
564 user->SetStubImage(base::WrapUnique(new user_manager::UserImage( 564 user->SetStubImage(base::MakeUnique<user_manager::UserImage>(
565 *ResourceBundle::GetSharedInstance().GetImageSkiaNamed( 565 *ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
566 IDR_PROFILE_PICTURE_LOADING))), 566 IDR_PROFILE_PICTURE_LOADING)),
567 image_index, true); 567 image_index, true);
568 DCHECK(!image_path.empty() || 568 DCHECK(!image_path.empty() ||
569 image_index == user_manager::User::USER_IMAGE_PROFILE); 569 image_index == user_manager::User::USER_IMAGE_PROFILE);
570 if (image_path.empty()) { 570 if (image_path.empty()) {
571 // Return if the profile image is to be used but has not been downloaded 571 // Return if the profile image is to be used but has not been downloaded
572 // yet. The profile image will be downloaded after login. 572 // yet. The profile image will be downloaded after login.
573 return; 573 return;
574 } 574 }
575 575
576 job_.reset(new Job(this)); 576 job_.reset(new Job(this));
(...skipping 386 matching lines...) Expand 10 before | Expand all | Expand 10 after
963 } 963 }
964 964
965 bool UserImageManagerImpl::IsUserLoggedInAndHasGaiaAccount() const { 965 bool UserImageManagerImpl::IsUserLoggedInAndHasGaiaAccount() const {
966 const user_manager::User* user = GetUser(); 966 const user_manager::User* user = GetUser();
967 if (!user) 967 if (!user)
968 return false; 968 return false;
969 return user->is_logged_in() && user->HasGaiaAccount(); 969 return user->is_logged_in() && user->HasGaiaAccount();
970 } 970 }
971 971
972 } // namespace chromeos 972 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698