Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc

Issue 2257103002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc
diff --git a/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc b/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc
index f7b27d77830973302b7fe84d2ec0976ba1968543..84b286244886ceacffad99333909357a62f9a6ee 100644
--- a/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc
+++ b/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc
@@ -358,7 +358,7 @@ TEST_F(NetworkConfigurationUpdaterTest, PolicyIsValidatedAndRepaired) {
PolicyMap policy;
policy.Set(key::kOpenNetworkConfiguration, POLICY_LEVEL_MANDATORY,
POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
- base::WrapUnique(new base::StringValue(onc_policy)), nullptr);
+ base::MakeUnique<base::StringValue>(onc_policy), nullptr);
UpdateProviderPolicy(policy);
EXPECT_CALL(network_config_handler_,
@@ -479,7 +479,7 @@ TEST_F(NetworkConfigurationUpdaterTest,
PolicyMap policy;
policy.Set(key::kOpenNetworkConfiguration, POLICY_LEVEL_MANDATORY,
POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
- base::WrapUnique(new base::StringValue(kFakeONC)), nullptr);
+ base::MakeUnique<base::StringValue>(kFakeONC), nullptr);
UpdateProviderPolicy(policy);
base::RunLoop().RunUntilIdle();
@@ -500,7 +500,7 @@ TEST_F(NetworkConfigurationUpdaterTest,
PolicyMap policy;
policy.Set(key::kOpenNetworkConfiguration, POLICY_LEVEL_MANDATORY,
POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
- base::WrapUnique(new base::StringValue(kFakeONC)), nullptr);
+ base::MakeUnique<base::StringValue>(kFakeONC), nullptr);
UpdateProviderPolicy(policy);
EXPECT_CALL(network_config_handler_,
@@ -567,8 +567,8 @@ class NetworkConfigurationUpdaterTestWithParam
TEST_P(NetworkConfigurationUpdaterTestWithParam, InitialUpdates) {
PolicyMap policy;
policy.Set(GetParam(), POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD,
- base::WrapUnique(new base::StringValue(kFakeONC)), nullptr);
+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::StringValue>(kFakeONC),
+ nullptr);
UpdateProviderPolicy(policy);
EXPECT_CALL(network_config_handler_,
@@ -589,8 +589,8 @@ TEST_P(NetworkConfigurationUpdaterTestWithParam,
PolicyNotSetBeforePolicyProviderInitialized) {
PolicyMap policy;
policy.Set(GetParam(), POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD,
- base::WrapUnique(new base::StringValue(kFakeONC)), nullptr);
+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::StringValue>(kFakeONC),
+ nullptr);
UpdateProviderPolicy(policy);
CreateNetworkConfigurationUpdater();
@@ -617,8 +617,8 @@ TEST_P(NetworkConfigurationUpdaterTestWithParam,
PolicyMap policy;
policy.Set(GetParam(), POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD,
- base::WrapUnique(new base::StringValue(kFakeONC)), nullptr);
+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::StringValue>(kFakeONC),
+ nullptr);
UpdateProviderPolicy(policy);
EXPECT_CALL(network_config_handler_,
@@ -657,8 +657,8 @@ TEST_P(NetworkConfigurationUpdaterTestWithParam, PolicyChange) {
PolicyMap policy;
policy.Set(GetParam(), POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD,
- base::WrapUnique(new base::StringValue(kFakeONC)), nullptr);
+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::StringValue>(kFakeONC),
+ nullptr);
UpdateProviderPolicy(policy);
Mock::VerifyAndClearExpectations(&network_config_handler_);
EXPECT_EQ(ExpectedImportCertificatesCallCount(),

Powered by Google App Engine
This is Rietveld 408576698