Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc

Issue 2257103002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/policy/device_local_account_policy_service.h" 5 #include "chrome/browser/chromeos/policy/device_local_account_policy_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 DeviceLocalAccount::TYPE_PUBLIC_SESSION)), 138 DeviceLocalAccount::TYPE_PUBLIC_SESSION)),
139 cros_settings_(&device_settings_service_), 139 cros_settings_(&device_settings_service_),
140 extension_cache_task_runner_(new base::TestSimpleTaskRunner) { 140 extension_cache_task_runner_(new base::TestSimpleTaskRunner) {
141 } 141 }
142 142
143 void DeviceLocalAccountPolicyServiceTestBase::SetUp() { 143 void DeviceLocalAccountPolicyServiceTestBase::SetUp() {
144 chromeos::DeviceSettingsTestBase::SetUp(); 144 chromeos::DeviceSettingsTestBase::SetUp();
145 145
146 expected_policy_map_.Set(key::kSearchSuggestEnabled, POLICY_LEVEL_MANDATORY, 146 expected_policy_map_.Set(key::kSearchSuggestEnabled, POLICY_LEVEL_MANDATORY,
147 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, 147 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
148 base::WrapUnique(new base::FundamentalValue(true)), 148 base::MakeUnique<base::FundamentalValue>(true),
149 nullptr); 149 nullptr);
150 150
151 device_local_account_policy_.payload() 151 device_local_account_policy_.payload()
152 .mutable_searchsuggestenabled() 152 .mutable_searchsuggestenabled()
153 ->set_value(true); 153 ->set_value(true);
154 device_local_account_policy_.policy_data().set_policy_type( 154 device_local_account_policy_.policy_data().set_policy_type(
155 dm_protocol::kChromePublicAccountPolicyType); 155 dm_protocol::kChromePublicAccountPolicyType);
156 } 156 }
157 157
158 void DeviceLocalAccountPolicyServiceTestBase::TearDown() { 158 void DeviceLocalAccountPolicyServiceTestBase::TearDown() {
(...skipping 643 matching lines...) Expand 10 before | Expand all | Expand 10 after
802 802
803 void DeviceLocalAccountPolicyProviderTest::SetUp() { 803 void DeviceLocalAccountPolicyProviderTest::SetUp() {
804 DeviceLocalAccountPolicyServiceTestBase::SetUp(); 804 DeviceLocalAccountPolicyServiceTestBase::SetUp();
805 provider_->Init(&schema_registry_); 805 provider_->Init(&schema_registry_);
806 provider_->AddObserver(&provider_observer_); 806 provider_->AddObserver(&provider_observer_);
807 807
808 // Values implicitly enforced for public accounts. 808 // Values implicitly enforced for public accounts.
809 expected_policy_map_.Set( 809 expected_policy_map_.Set(
810 key::kLidCloseAction, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, 810 key::kLidCloseAction, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
811 POLICY_SOURCE_PUBLIC_SESSION_OVERRIDE, 811 POLICY_SOURCE_PUBLIC_SESSION_OVERRIDE,
812 base::WrapUnique(new base::FundamentalValue( 812 base::MakeUnique<base::FundamentalValue>(
813 chromeos::PowerPolicyController::ACTION_STOP_SESSION)), 813 chromeos::PowerPolicyController::ACTION_STOP_SESSION),
814 nullptr); 814 nullptr);
815 expected_policy_map_.Set( 815 expected_policy_map_.Set(
816 key::kShelfAutoHideBehavior, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, 816 key::kShelfAutoHideBehavior, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
817 POLICY_SOURCE_PUBLIC_SESSION_OVERRIDE, 817 POLICY_SOURCE_PUBLIC_SESSION_OVERRIDE,
818 base::WrapUnique(new base::StringValue("Never")), nullptr); 818 base::MakeUnique<base::StringValue>("Never"), nullptr);
819 expected_policy_map_.Set( 819 expected_policy_map_.Set(
820 key::kShowLogoutButtonInTray, POLICY_LEVEL_MANDATORY, 820 key::kShowLogoutButtonInTray, POLICY_LEVEL_MANDATORY,
821 POLICY_SCOPE_MACHINE, POLICY_SOURCE_PUBLIC_SESSION_OVERRIDE, 821 POLICY_SCOPE_MACHINE, POLICY_SOURCE_PUBLIC_SESSION_OVERRIDE,
822 base::WrapUnique(new base::FundamentalValue(true)), nullptr); 822 base::MakeUnique<base::FundamentalValue>(true), nullptr);
823 expected_policy_map_.Set( 823 expected_policy_map_.Set(
824 key::kFullscreenAllowed, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, 824 key::kFullscreenAllowed, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
825 POLICY_SOURCE_PUBLIC_SESSION_OVERRIDE, 825 POLICY_SOURCE_PUBLIC_SESSION_OVERRIDE,
826 base::WrapUnique(new base::FundamentalValue(false)), nullptr); 826 base::MakeUnique<base::FundamentalValue>(false), nullptr);
827 } 827 }
828 828
829 void DeviceLocalAccountPolicyProviderTest::TearDown() { 829 void DeviceLocalAccountPolicyProviderTest::TearDown() {
830 provider_->RemoveObserver(&provider_observer_); 830 provider_->RemoveObserver(&provider_observer_);
831 provider_->Shutdown(); 831 provider_->Shutdown();
832 provider_.reset(); 832 provider_.reset();
833 DeviceLocalAccountPolicyServiceTestBase::TearDown(); 833 DeviceLocalAccountPolicyServiceTestBase::TearDown();
834 } 834 }
835 835
836 TEST_F(DeviceLocalAccountPolicyProviderTest, Initialization) { 836 TEST_F(DeviceLocalAccountPolicyProviderTest, Initialization) {
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
881 service_->GetBrokerForUser(account_1_user_id_); 881 service_->GetBrokerForUser(account_1_user_id_);
882 ASSERT_TRUE(broker); 882 ASSERT_TRUE(broker);
883 broker->core()->store()->Load(); 883 broker->core()->store()->Load();
884 FlushDeviceSettings(); 884 FlushDeviceSettings();
885 Mock::VerifyAndClearExpectations(&provider_observer_); 885 Mock::VerifyAndClearExpectations(&provider_observer_);
886 886
887 expected_policy_bundle 887 expected_policy_bundle
888 .Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())) 888 .Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
889 .Set(key::kSearchSuggestEnabled, POLICY_LEVEL_MANDATORY, 889 .Set(key::kSearchSuggestEnabled, POLICY_LEVEL_MANDATORY,
890 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, 890 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
891 base::WrapUnique(new base::FundamentalValue(false)), nullptr); 891 base::MakeUnique<base::FundamentalValue>(false), nullptr);
892 EXPECT_TRUE(expected_policy_bundle.Equals(provider_->policies())); 892 EXPECT_TRUE(expected_policy_bundle.Equals(provider_->policies()));
893 893
894 // Any values set for the |ShelfAutoHideBehavior|, |ShowLogoutButtonInTray| 894 // Any values set for the |ShelfAutoHideBehavior|, |ShowLogoutButtonInTray|
895 // and |ExtensionAllowedTypes| policies should be overridden. 895 // and |ExtensionAllowedTypes| policies should be overridden.
896 EXPECT_CALL(provider_observer_, OnUpdatePolicy(provider_.get())) 896 EXPECT_CALL(provider_observer_, OnUpdatePolicy(provider_.get()))
897 .Times(AtLeast(1)); 897 .Times(AtLeast(1));
898 device_local_account_policy_.payload().mutable_shelfautohidebehavior()-> 898 device_local_account_policy_.payload().mutable_shelfautohidebehavior()->
899 set_value("Always"); 899 set_value("Always");
900 device_local_account_policy_.payload().mutable_showlogoutbuttonintray()-> 900 device_local_account_policy_.payload().mutable_showlogoutbuttonintray()->
901 set_value(false); 901 set_value(false);
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
970 em::DeviceManagementResponse response; 970 em::DeviceManagementResponse response;
971 device_local_account_policy_.Build(); 971 device_local_account_policy_.Build();
972 response.mutable_policy_response()->add_response()->CopyFrom( 972 response.mutable_policy_response()->add_response()->CopyFrom(
973 device_local_account_policy_.policy()); 973 device_local_account_policy_.policy());
974 request_job->SendResponse(DM_STATUS_SUCCESS, response); 974 request_job->SendResponse(DM_STATUS_SUCCESS, response);
975 FlushDeviceSettings(); 975 FlushDeviceSettings();
976 Mock::VerifyAndClearExpectations(&provider_observer_); 976 Mock::VerifyAndClearExpectations(&provider_observer_);
977 } 977 }
978 978
979 } // namespace policy 979 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698