chrome/browser/chromeos/policy/system_log_uploader.cc - Issue 2257103002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/system_log_uploader.cc

Issue 2257103002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/status_uploader_unittest.cc ('k') | chrome/browser/chromeos/policy/system_log_uploader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/system_log_uploader.cc

diff --git a/chrome/browser/chromeos/policy/system_log_uploader.cc b/chrome/browser/chromeos/policy/system_log_uploader.cc

index 12e895dc9dcc2221c39f7fdae26628636a277a74..c3da610edf197ec273d9014434fed16a7012b644 100644

--- a/chrome/browser/chromeos/policy/system_log_uploader.cc

+++ b/chrome/browser/chromeos/policy/system_log_uploader.cc

@@ -267,7 +267,7 @@ void SystemLogUploader::UploadSystemLogs(

for (const auto& syslog_entry : *system_logs) {

std::map<std::string, std::string> header_fields;

std::unique_ptr<std::string> data =

- base::WrapUnique(new std::string(syslog_entry.second));

+ base::MakeUnique<std::string>(syslog_entry.second);

header_fields.insert(std::make_pair(kFileTypeHeaderName, kFileTypeLogFile));

header_fields.insert(std::make_pair(net::HttpRequestHeaders::kContentType,

kContentTypePlainText));