Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc

Issue 2257103002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
diff --git a/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc b/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
index d44a5bbd6973b8d1f1411ebcd72d3d17ecbc36da..b97b51a4116eaa15a80684c327af073db9df4918 100644
--- a/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
+++ b/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
@@ -93,7 +93,7 @@ class QuickUnlockPrivateUnitTest : public ExtensionApiUnittest {
// Run the function.
std::unique_ptr<base::Value> result =
RunFunction(new QuickUnlockPrivateGetAvailableModesFunction(),
- base::WrapUnique(new base::ListValue()));
+ base::MakeUnique<base::ListValue>());
// Extract the results.
QuickUnlockModeList modes;
@@ -114,7 +114,7 @@ class QuickUnlockPrivateUnitTest : public ExtensionApiUnittest {
QuickUnlockModeList GetActiveModes() {
std::unique_ptr<base::Value> result =
RunFunction(new QuickUnlockPrivateGetActiveModesFunction(),
- base::WrapUnique(new base::ListValue()));
+ base::MakeUnique<base::ListValue>());
QuickUnlockModeList modes;
@@ -141,15 +141,15 @@ class QuickUnlockPrivateUnitTest : public ExtensionApiUnittest {
const QuickUnlockModeList& modes,
const CredentialList& passwords) {
// Serialize parameters.
- auto params = base::WrapUnique(new base::ListValue());
+ auto params = base::MakeUnique<base::ListValue>();
params->AppendString(password);
- auto serialized_modes = base::WrapUnique(new base::ListValue());
+ auto serialized_modes = base::MakeUnique<base::ListValue>();
for (QuickUnlockMode mode : modes)
serialized_modes->AppendString(quick_unlock_private::ToString(mode));
params->Append(std::move(serialized_modes));
- auto serialized_passwords = base::WrapUnique(new base::ListValue());
+ auto serialized_passwords = base::MakeUnique<base::ListValue>();
for (const std::string& password : passwords)
serialized_passwords->AppendString(password);
params->Append(std::move(serialized_passwords));
@@ -202,7 +202,7 @@ class QuickUnlockPrivateUnitTest : public ExtensionApiUnittest {
return std::unique_ptr<base::Value>(
api_test_utils::RunFunctionWithDelegateAndReturnSingleResult(
func, std::move(params), profile(),
- base::WrapUnique(new ExtensionFunctionDispatcher(profile())),
+ base::MakeUnique<ExtensionFunctionDispatcher>(profile()),
api_test_utils::NONE));
}

Powered by Google App Engine
This is Rietveld 408576698