chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc - Issue 2257103002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc

Issue 2257103002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc ('k') | chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc

diff --git a/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc b/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc

index 048af45de189cfe234738fd348c48fe1502e03ad..c5730b1b9bd9a7ea0ced8a7b2924311a904eefe1 100644

--- a/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc

+++ b/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc

@@ -156,10 +156,10 @@ class UserCloudPolicyStoreChromeOSTest : public testing::Test {

PolicyMap previous_policy;

EXPECT_EQ(previous_value != NULL, store_->policy() != NULL);

if (previous_value) {

- previous_policy.Set(

- key::kHomepageLocation, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

- POLICY_SOURCE_CLOUD,

- base::WrapUnique(new base::StringValue(previous_value)), nullptr);

+ previous_policy.Set(key::kHomepageLocation, POLICY_LEVEL_MANDATORY,

+ POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

+ base::MakeUnique<base::StringValue>(previous_value),

+ nullptr);

}

EXPECT_TRUE(previous_policy.Equals(store_->policy_map()));

EXPECT_EQ(CloudPolicyStore::STATUS_OK, store_->status());