chrome/browser/chromeos/display/display_preferences_unittest.cc - Issue 2257103002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/display/display_preferences_unittest.cc

Issue 2257103002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/chrome_browser_main_chromeos.cc ('k') | chrome/browser/chromeos/extensions/file_manager/event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/display/display_preferences_unittest.cc

diff --git a/chrome/browser/chromeos/display/display_preferences_unittest.cc b/chrome/browser/chromeos/display/display_preferences_unittest.cc

index 7f29b8f723ba4e6178ecf05483ec888c51d330f0..53aecf5f7ff7046540931489a587d33af2cb5136 100644

--- a/chrome/browser/chromeos/display/display_preferences_unittest.cc

+++ b/chrome/browser/chromeos/display/display_preferences_unittest.cc

@@ -154,7 +154,7 @@ class DisplayPreferencesTest : public ash::test::AshTestBase {

const std::string& key,

bool value) {

StoreDisplayPropertyForList(

- list, key, base::WrapUnique(new base::FundamentalValue(value)));

+ list, key, base::MakeUnique<base::FundamentalValue>(value));

}

void StoreDisplayLayoutPrefForList(const display::DisplayIdList& list,

@@ -1036,7 +1036,7 @@ TEST_F(DisplayPreferencesTest, RestoreUnifiedMode) {

StoreDisplayBoolPropertyForList(list, "default_unified", true);

StoreDisplayPropertyForList(

list, "primary-id",

- base::WrapUnique(new base::StringValue(base::Int64ToString(id1))));

+ base::MakeUnique<base::StringValue>(base::Int64ToString(id1)));

LoadDisplayPreferences(false);

// Should not restore to unified unless unified desktop is enabled.