Have the RequestCoordinator generate the offline_id

So that the RequestCoordinator can return the offline id
of the saved page, we make it the same as the request id.

So, the RequestCoordinator will generate an offline ID, and it will get passed through to the OfflinePageModel's SavePage
method (by the prerendering offliner), which will be used
when the page is saved.

BUG=610521
Committed: https://crrev.com/1c20830eec369c944377f806b4a025e19ead9475
Cr-Commit-Position: refs/heads/master@{#412315}

[Pete Williamson, 2016-08-11 00:32:14]

The CQ bit was checked by petewil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 00:33:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 01:17:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 01:17:20]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Pete Williamson, 2016-08-15 20:08:16]

The CQ bit was checked by petewil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 20:08:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Pete Williamson, 2016-08-15 20:10:22]

Description was changed from

==========
Returns the OfflineId when the prerenderer finishes (successfully).

The RequestCoordinator needs the offline_id to send with a notification,
but it is not being provided yet.  It is easily available, we just need
to widen the callback parameters to include it.

BUG=610521
==========

to

==========
So that the RequestCoordinator can return the offline id
of the saved page, we make it the same as the request id.

So, the RequestCoordinator will generate an offline ID, and it will get passed
through to the OfflinePageModel's SavePage
method (by the prerendering offliner), which will be used
when the page is saved.

BUG=610521
==========

[Pete Williamson, 2016-08-15 20:10:58]

petewil@chromium.org changed reviewers:
+ dimich@chromium.org

[commit-bot: I haz the power, 2016-08-15 20:28:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 20:29:00]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Pete Williamson, 2016-08-15 22:14:23]

The CQ bit was checked by petewil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 22:14:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 22:46:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 22:46:41]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Pete Williamson, 2016-08-15 23:51:40]

The CQ bit was checked by petewil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 23:52:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 23:54:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 23:54:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Pete Williamson, 2016-08-16 01:07:51]

The changelist failed to merge, might want to hold off reviewing until I have it
merged and passing tests.

[Dmitry Titov, 2016-08-16 02:25:00]

https://codereview.chromium.org/2234873004/diff/60001/chrome/browser/android/...
File chrome/browser/android/offline_pages/prerendering_offliner.h (right):

https://codereview.chromium.org/2234873004/diff/60001/chrome/browser/android/...
chrome/browser/android/offline_pages/prerendering_offliner.h:56: int64_t
offline_id,
Naming suggestion: maybe proposed_offline_id? To capture the spirit that it is
optional, can be 0 which means no proposed or suggested id is passed in.

https://codereview.chromium.org/2234873004/diff/60001/components/offline_page...
File components/offline_pages/offline_page_model_impl.cc (right):

https://codereview.chromium.org/2234873004/diff/60001/components/offline_page...
components/offline_pages/offline_page_model_impl.cc:298: if (offline_id == 0ul)
This should go into the comment for SavePage method in .h file. This is
important part of the contract.

[Pete Williamson, 2016-08-16 18:54:50]

The CQ bit was checked by petewil@chromium.org to run a CQ dry run

[Pete Williamson, 2016-08-16 18:54:56]

https://codereview.chromium.org/2234873004/diff/60001/chrome/browser/android/...
File chrome/browser/android/offline_pages/prerendering_offliner.h (right):

https://codereview.chromium.org/2234873004/diff/60001/chrome/browser/android/...
chrome/browser/android/offline_pages/prerendering_offliner.h:56: int64_t
offline_id,
On 2016/08/16 02:25:00, Dmitry Titov wrote:
> Naming suggestion: maybe proposed_offline_id? To capture the spirit that it is
> optional, can be 0 which means no proposed or suggested id is passed in.

Done.

https://codereview.chromium.org/2234873004/diff/60001/components/offline_page...
File components/offline_pages/offline_page_model_impl.cc (right):

https://codereview.chromium.org/2234873004/diff/60001/components/offline_page...
components/offline_pages/offline_page_model_impl.cc:298: if (offline_id == 0ul)
On 2016/08/16 02:25:00, Dmitry Titov wrote:
> This should go into the comment for SavePage method in .h file. This is
> important part of the contract.

Done.

[commit-bot: I haz the power, 2016-08-16 18:55:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dmitry Titov, 2016-08-16 19:18:13]

lgtm

[commit-bot: I haz the power, 2016-08-16 20:01:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 20:01:29]

Dry run: This issue passed the CQ dry run.

[Pete Williamson, 2016-08-16 20:04:09]

The CQ bit was checked by petewil@chromium.org

[commit-bot: I haz the power, 2016-08-16 20:05:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 20:10:35]

Description was changed from

==========
So that the RequestCoordinator can return the offline id
of the saved page, we make it the same as the request id.

So, the RequestCoordinator will generate an offline ID, and it will get passed
through to the OfflinePageModel's SavePage
method (by the prerendering offliner), which will be used
when the page is saved.

BUG=610521
==========

to

==========
So that the RequestCoordinator can return the offline id
of the saved page, we make it the same as the request id.

So, the RequestCoordinator will generate an offline ID, and it will get passed
through to the OfflinePageModel's SavePage
method (by the prerendering offliner), which will be used
when the page is saved.

BUG=610521
==========

[commit-bot: I haz the power, 2016-08-16 20:10:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-16 20:13:53]

Description was changed from

==========
So that the RequestCoordinator can return the offline id
of the saved page, we make it the same as the request id.

So, the RequestCoordinator will generate an offline ID, and it will get passed
through to the OfflinePageModel's SavePage
method (by the prerendering offliner), which will be used
when the page is saved.

BUG=610521
==========

to

==========
So that the RequestCoordinator can return the offline id
of the saved page, we make it the same as the request id.

So, the RequestCoordinator will generate an offline ID, and it will get passed
through to the OfflinePageModel's SavePage
method (by the prerendering offliner), which will be used
when the page is saved.

BUG=610521

Committed: https://crrev.com/1c20830eec369c944377f806b4a025e19ead9475
Cr-Commit-Position: refs/heads/master@{#412315}
==========

[commit-bot: I haz the power, 2016-08-16 20:13:54]

Patchset 5 (id:??) landed as
https://crrev.com/1c20830eec369c944377f806b4a025e19ead9475
Cr-Commit-Position: refs/heads/master@{#412315}

[dougarnett, 2016-08-18 17:59:07]

dougarnett@chromium.org changed reviewers:
+ dougarnett@chromium.org

[dougarnett, 2016-08-18 17:59:08]

late look

https://codereview.chromium.org/2234873004/diff/80001/chrome/browser/android/...
File chrome/browser/android/offline_pages/recent_tab_helper.cc (right):

https://codereview.chromium.org/2234873004/diff/80001/chrome/browser/android/...
chrome/browser/android/offline_pages/recent_tab_helper.cc:169:
page_model_->SavePage(snapshot_url_, client_id(), 0ul,
possibly dumb C++ question: why are you using "u" when the type seems to be
signed (int64_t)?

https://codereview.chromium.org/2234873004/diff/80001/components/offline_page...
File components/offline_pages/offline_page_model_impl.cc (right):

https://codereview.chromium.org/2234873004/diff/80001/components/offline_page...
components/offline_pages/offline_page_model_impl.cc:299: if (proposed_offline_id
== 0ul)
negative proposed ids ok?