chrome/browser/android/offline_pages/recent_tab_helper.cc - Issue 2234873004: Have the RequestCoordinator generate the offline_id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/recent_tab_helper.cc

Issue 2234873004: Have the RequestCoordinator generate the offline_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge, and CR fixes per Dimich Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc ('k') | components/offline_pages/background/request_coordinator.cc » ('j') | components/offline_pages/offline_page_model_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/recent_tab_helper.cc

diff --git a/chrome/browser/android/offline_pages/recent_tab_helper.cc b/chrome/browser/android/offline_pages/recent_tab_helper.cc

index ac82fd680ee34baba94f8ee6dc00f03a958fe731..2d4767ffc996ecfeaa8ec6824f76c3d8807a4c11 100644

--- a/chrome/browser/android/offline_pages/recent_tab_helper.cc

+++ b/chrome/browser/android/offline_pages/recent_tab_helper.cc

@@ -166,11 +166,10 @@ void RecentTabHelper::ContinueSnapshotAfterPurge(

return;

}

- page_model_->SavePage(

- snapshot_url_, client_id(),

- delegate_->CreatePageArchiver(web_contents()),

- base::Bind(&RecentTabHelper::SavePageCallback,

- weak_ptr_factory_.GetWeakPtr()));

+ page_model_->SavePage(snapshot_url_, client_id(), 0ul,

dougarnett 2016/08/18 17:59:07 possibly dumb C++ question: why are you using "u"

+ delegate_->CreatePageArchiver(web_contents()),

+ base::Bind(&RecentTabHelper::SavePageCallback,

+ weak_ptr_factory_.GetWeakPtr()));

}

void RecentTabHelper::SavePageCallback(OfflinePageModel::SavePageResult result,