chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc - Issue 2234873004: Have the RequestCoordinator generate the offline_id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

Issue 2234873004: Have the RequestCoordinator generate the offline_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge, and CR fixes per Dimich Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_bridge.cc » ('j') | chrome/browser/android/offline_pages/recent_tab_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

diff --git a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

index 7bdeaa05c512c94443e2d3ea195ee29ae5abbf44..a99688924993a3784e749a2552230bdfe8954bf3 100644

--- a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

+++ b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

@@ -148,7 +148,7 @@ void OfflinePageDownloadBridge::StartDownload(

client_id.id = base::GenerateGUID();

offline_page_model->SavePage(

- url, client_id, std::move(archiver),

+ url, client_id, 0ul, std::move(archiver),

base::Bind(&OfflinePageDownloadBridge::SavePageCallback,

weak_ptr_factory_.GetWeakPtr()));

}

« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_bridge.cc » ('j') | chrome/browser/android/offline_pages/recent_tab_helper.cc » ('J')