chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc - Issue 2234873004: Have the RequestCoordinator generate the offline_id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

Issue 2234873004: Have the RequestCoordinator generate the offline_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge, and CR fixes per Dimich Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/prerendering_offliner.cc ('k') | chrome/browser/android/offline_pages/recent_tab_helper.cc » ('j') | chrome/browser/android/offline_pages/recent_tab_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

diff --git a/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc b/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

index c85f384575de5fc43309aa537e3d7f8826ddcde2..bc46bc604f2881beccaf3a5fffb5d02ee7ccd035 100644

--- a/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

+++ b/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

@@ -104,6 +104,7 @@ class MockOfflinePageModel : public StubOfflinePageModel {

void SavePage(const GURL& url,

const ClientId& client_id,

+ int64_t proposed_offline_id,

std::unique_ptr<OfflinePageArchiver> archiver,

const SavePageCallback& callback) override {

mock_saving_ = true;