Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: components/offline_pages/offline_page_model.h

Issue 2234873004: Have the RequestCoordinator generate the offline_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge, and CR fixes per Dimich Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model.h
diff --git a/components/offline_pages/offline_page_model.h b/components/offline_pages/offline_page_model.h
index 07aa4ed367ef62744ee2472cf00dd3bdd2b87dc6..72f9d41778e11e2739c09ee320dc480b49a6a854 100644
--- a/components/offline_pages/offline_page_model.h
+++ b/components/offline_pages/offline_page_model.h
@@ -82,9 +82,12 @@ class OfflinePageModel : public base::SupportsUserData {
virtual void RemoveObserver(Observer* observer) = 0;
// Attempts to save a page addressed by |url| offline. Requires that the model
- // is loaded. Generates a new offline id and returns it.
+ // is loaded. Generates a new offline id and returns
+ // it. |proposed_offline_id| is used for the offline_id for the saved file if
+ // it is non-zero. If it is zero, a new, random ID will be generated.
virtual void SavePage(const GURL& url,
const ClientId& client_id,
+ int64_t proposed_offline_id,
std::unique_ptr<OfflinePageArchiver> archiver,
const SavePageCallback& callback) = 0;

Powered by Google App Engine
This is Rietveld 408576698