Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: components/offline_pages/offline_page_model_impl.cc

Issue 2234873004: Have the RequestCoordinator generate the offline_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge, and CR fixes per Dimich Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl.cc
diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc
index a91a752eaa657eee72857f80492cabce6ae8d7f8..7b9ca4419eb03f3d794c337a13bb5575de34fec7 100644
--- a/components/offline_pages/offline_page_model_impl.cc
+++ b/components/offline_pages/offline_page_model_impl.cc
@@ -275,6 +275,7 @@ void OfflinePageModelImpl::RemoveObserver(Observer* observer) {
void OfflinePageModelImpl::SavePage(
const GURL& url,
const ClientId& client_id,
+ int64_t proposed_offline_id,
std::unique_ptr<OfflinePageArchiver> archiver,
const SavePageCallback& callback) {
DCHECK(is_loaded_);
@@ -294,13 +295,15 @@ void OfflinePageModelImpl::SavePage(
return;
}
- int64_t offline_id = GenerateOfflineId();
+ // If we already have an offline id, use it. If not, generate one.
+ if (proposed_offline_id == 0ul)
dougarnett 2016/08/18 17:59:07 negative proposed ids ok?
+ proposed_offline_id = GenerateOfflineId();
archiver->CreateArchive(
- archives_dir_, offline_id,
+ archives_dir_, proposed_offline_id,
base::Bind(&OfflinePageModelImpl::OnCreateArchiveDone,
- weak_ptr_factory_.GetWeakPtr(), url, offline_id, client_id,
- base::Time::Now(), callback));
+ weak_ptr_factory_.GetWeakPtr(), url, proposed_offline_id,
+ client_id, base::Time::Now(), callback));
pending_archivers_.push_back(std::move(archiver));
}

Powered by Google App Engine
This is Rietveld 408576698