components/offline_pages/offline_page_model_impl.h - Issue 2234873004: Have the RequestCoordinator generate the offline_id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model_impl.h

Issue 2234873004: Have the RequestCoordinator generate the offline_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge, and CR fixes per Dimich Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/offline_pages/recent_tab_helper.cc ('K') | « components/offline_pages/offline_page_model.h ('k') | components/offline_pages/offline_page_model_impl.cc » ('j') | components/offline_pages/offline_page_model_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_model_impl.h

diff --git a/components/offline_pages/offline_page_model_impl.h b/components/offline_pages/offline_page_model_impl.h

index 9ea4f3fcd06c70710d4990196209cc42062c294b..06c9e43434904689f4215b6bd68c2f29464de304 100644

--- a/components/offline_pages/offline_page_model_impl.h

+++ b/components/offline_pages/offline_page_model_impl.h

@@ -68,6 +68,7 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {

void RemoveObserver(Observer* observer) override;

void SavePage(const GURL& url,

const ClientId& client_id,

+ int64_t proposed_offline_id,

std::unique_ptr<OfflinePageArchiver> archiver,

const SavePageCallback& callback) override;

void MarkPageAccessed(int64_t offline_id) override;