Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3308)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.h

Issue 2234873004: Have the RequestCoordinator generate the offline_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge, and CR fixes per Dimich Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner.h
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.h b/chrome/browser/android/offline_pages/prerendering_offliner.h
index 83d09d06b4add1aa5b7174ebfcaf19d8390b2c71..fd0f20a7966cad1f4ce71e6b9b493b7ae2b6756f 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.h
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.h
@@ -48,11 +48,13 @@ class PrerenderingOffliner : public Offliner {
base::android::ApplicationState application_state);
protected:
- // Internal method for requesting OfflinePageModel to save page.
- // Exposed for unit testing.
+ // Internal method for requesting OfflinePageModel to save page. Exposed for
+ // unit testing. |proposed_offline_id| will be used if non-zero. If it is
+ // zero, a new, random, id will be generated instead.
// TODO(dougarnett): Consider making OfflinePageModel mockable instead.
virtual void SavePage(const GURL& url,
const ClientId& client_id,
+ int64_t proposed_offline_id,
std::unique_ptr<OfflinePageArchiver> archiver,
const SavePageCallback& save_callback);

Powered by Google App Engine
This is Rietveld 408576698