Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Side by Side Diff: chrome/browser/android/offline_pages/prerendering_offliner.h

Issue 2234873004: Have the RequestCoordinator generate the offline_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge, and CR fixes per Dimich Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_OFFLINER_H_ 5 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_OFFLINER_H_
6 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_OFFLINER_H_ 6 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_OFFLINER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/android/application_status_listener.h" 10 #include "base/android/application_status_listener.h"
(...skipping 30 matching lines...) Expand all
41 // Allows a loader to be injected for testing. This may only be done once 41 // Allows a loader to be injected for testing. This may only be done once
42 // and must be called before any of the Offliner interface methods are called. 42 // and must be called before any of the Offliner interface methods are called.
43 void SetLoaderForTesting(std::unique_ptr<PrerenderingLoader> loader); 43 void SetLoaderForTesting(std::unique_ptr<PrerenderingLoader> loader);
44 44
45 void SetLowEndDeviceForTesting(bool is_low_end_device); 45 void SetLowEndDeviceForTesting(bool is_low_end_device);
46 46
47 void SetApplicationStateForTesting( 47 void SetApplicationStateForTesting(
48 base::android::ApplicationState application_state); 48 base::android::ApplicationState application_state);
49 49
50 protected: 50 protected:
51 // Internal method for requesting OfflinePageModel to save page. 51 // Internal method for requesting OfflinePageModel to save page. Exposed for
52 // Exposed for unit testing. 52 // unit testing. |proposed_offline_id| will be used if non-zero. If it is
53 // zero, a new, random, id will be generated instead.
53 // TODO(dougarnett): Consider making OfflinePageModel mockable instead. 54 // TODO(dougarnett): Consider making OfflinePageModel mockable instead.
54 virtual void SavePage(const GURL& url, 55 virtual void SavePage(const GURL& url,
55 const ClientId& client_id, 56 const ClientId& client_id,
57 int64_t proposed_offline_id,
56 std::unique_ptr<OfflinePageArchiver> archiver, 58 std::unique_ptr<OfflinePageArchiver> archiver,
57 const SavePageCallback& save_callback); 59 const SavePageCallback& save_callback);
58 60
59 private: 61 private:
60 // Callback logic for PrerenderingLoader::LoadPage(). 62 // Callback logic for PrerenderingLoader::LoadPage().
61 void OnLoadPageDone(const SavePageRequest& request, 63 void OnLoadPageDone(const SavePageRequest& request,
62 Offliner::RequestStatus load_status, 64 Offliner::RequestStatus load_status,
63 content::WebContents* web_contents); 65 content::WebContents* web_contents);
64 66
65 // Callback logic for OfflinePageModel::SavePage(). 67 // Callback logic for OfflinePageModel::SavePage().
(...skipping 23 matching lines...) Expand all
89 // ApplicationStatusListener to monitor if the Chrome moves to the foreground. 91 // ApplicationStatusListener to monitor if the Chrome moves to the foreground.
90 std::unique_ptr<base::android::ApplicationStatusListener> app_listener_; 92 std::unique_ptr<base::android::ApplicationStatusListener> app_listener_;
91 base::WeakPtrFactory<PrerenderingOffliner> weak_ptr_factory_; 93 base::WeakPtrFactory<PrerenderingOffliner> weak_ptr_factory_;
92 94
93 DISALLOW_COPY_AND_ASSIGN(PrerenderingOffliner); 95 DISALLOW_COPY_AND_ASSIGN(PrerenderingOffliner);
94 }; 96 };
95 97
96 } // namespace offline_pages 98 } // namespace offline_pages
97 99
98 #endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_OFFLINER_H_ 100 #endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_OFFLINER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698