Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.cc

Issue 2234873004: Have the RequestCoordinator generate the offline_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge, and CR fixes per Dimich Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.cc b/chrome/browser/android/offline_pages/prerendering_offliner.cc
index e86f3cb259272620693d3820df243bc53733abd3..ccd2c7ee40b6ada8676e21f4be56d629017e83de 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.cc
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.cc
@@ -61,7 +61,7 @@ void PrerenderingOffliner::OnLoadPageDone(
// same as LastCommittedURL from the snapshot.
// TODO(dougarnett): Raise issue of how to better deal with redirects.
SavePage(web_contents->GetLastCommittedURL(), request.client_id(),
- std::move(archiver),
+ request.request_id(), std::move(archiver),
base::Bind(&PrerenderingOffliner::OnSavePageDone,
weak_ptr_factory_.GetWeakPtr(), request));
} else {
@@ -171,11 +171,12 @@ void PrerenderingOffliner::SetApplicationStateForTesting(
void PrerenderingOffliner::SavePage(
const GURL& url,
const ClientId& client_id,
+ int64_t proposed_offline_id,
std::unique_ptr<OfflinePageArchiver> archiver,
const SavePageCallback& save_callback) {
DCHECK(offline_page_model_);
- offline_page_model_->SavePage(url, client_id, std::move(archiver),
- save_callback);
+ offline_page_model_->SavePage(url, client_id, proposed_offline_id,
+ std::move(archiver), save_callback);
}
PrerenderingLoader* PrerenderingOffliner::GetOrCreateLoader() {

Powered by Google App Engine
This is Rietveld 408576698