Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc

Issue 2234873004: Have the RequestCoordinator generate the offline_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge, and CR fixes per Dimich Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc b/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
index 456f44c7cae1e1cc42edf00ab198169a898936e9..d061b5c731f65fffbf17a1bcc403430bbd4758ce 100644
--- a/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
+++ b/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
@@ -175,7 +175,7 @@ void OfflinePageTabHelperTest::SetUp() {
std::unique_ptr<OfflinePageTestArchiver> archiver(BuildArchiver(
kTestPageUrl, base::FilePath(FILE_PATH_LITERAL("page1.mhtml"))));
model->SavePage(
- kTestPageUrl, kTestClientId, std::move(archiver),
+ kTestPageUrl, kTestClientId, 0ul, std::move(archiver),
base::Bind(&OfflinePageTabHelperTest::OnSavePageDone, AsWeakPtr()));
RunUntilIdle();
}
@@ -346,7 +346,7 @@ TEST_F(OfflinePageTabHelperTest, SelectBestPageForCurrentTab) {
// We expect this copy to be used later.
ClientId client_id(kLastNNamespace, base::IntToString(kTabId));
model->SavePage(
- kTestPageUrl, client_id, std::move(archiver),
+ kTestPageUrl, client_id, 0ul, std::move(archiver),
base::Bind(&OfflinePageTabHelperTest::OnSavePageDone, AsWeakPtr()));
RunUntilIdle();
const int64_t expected_offline_id = offline_id();
@@ -356,7 +356,7 @@ TEST_F(OfflinePageTabHelperTest, SelectBestPageForCurrentTab) {
base::FilePath(FILE_PATH_LITERAL("page3.html")));
client_id.id = "39";
model->SavePage(
- kTestPageUrl, client_id, std::move(archiver),
+ kTestPageUrl, client_id, 0ul, std::move(archiver),
base::Bind(&OfflinePageTabHelperTest::OnSavePageDone, AsWeakPtr()));
RunUntilIdle();
@@ -427,7 +427,7 @@ TEST_F(OfflinePageTabHelperTest, SwitchToOfflineAsyncLoadedPageOnNoNetwork) {
// We expect this Async Loading Namespace copy to be used.
ClientId client_id(kAsyncNamespace, base::IntToString(kTabId));
model->SavePage(
- kTestPageUrl, client_id, std::move(archiver),
+ kTestPageUrl, client_id, 0ul, std::move(archiver),
base::Bind(&OfflinePageTabHelperTest::OnSavePageDone, AsWeakPtr()));
RunUntilIdle();
const int64_t expected_offline_id = offline_id();

Powered by Google App Engine
This is Rietveld 408576698