[DevTools] Dont pass errorString to async protocol methods

[DevTools] Dont pass errorString to async protocol methods

BUG=none
R=dgozman@chromium.org,pfeldman@chromium.org

Committed: https://crrev.com/727e8621bd1e32c9d64752fae18175193c9d9db1
Cr-Commit-Position: refs/heads/master@{#409275}

[kozy, 2016-08-01 20:06:40]

Dmitry, please take a look!

[dgozman, 2016-08-01 22:48:30]

Sorry, it's hard to review templates without proper indentation.

https://codereview.chromium.org/2203543002/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template
(right):

https://codereview.chromium.org/2203543002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template:329:
{%- else %}
You have to preserve the indentation of control-flow constructions as well.

https://codereview.chromium.org/2203543002/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template
(right):

https://codereview.chromium.org/2203543002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template:217:
{%- for parameter in command.parameters -%}
ditto

[kozy, 2016-08-02 00:42:39]

please take a look!

https://codereview.chromium.org/2203543002/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template
(right):

https://codereview.chromium.org/2203543002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template:329:
{%- else %}
On 2016/08/01 22:48:30, dgozman wrote:
> You have to preserve the indentation of control-flow constructions as well.

Done.

https://codereview.chromium.org/2203543002/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template
(right):

https://codereview.chromium.org/2203543002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template:217:
{%- for parameter in command.parameters -%}
On 2016/08/01 22:48:30, dgozman wrote:
> ditto

Done.

[dgozman, 2016-08-02 01:45:06]

lgtm

[kozy, 2016-08-02 02:25:20]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-08-02 02:25:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-08-02 02:25:43]

Description was changed from

==========
[DevTools] Dont pass errorString to async protocol methods

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] Dont pass errorString to async protocol methods

BUG=none
R=dgozman@chromium.org,pfeldman@chromium.org
==========

[kozy, 2016-08-02 02:25:44]

kozyatinskiy@chromium.org changed reviewers:
+ pfeldman@chromium.org

[kozy, 2016-08-02 02:25:58]

Pavel, please take a look!

[commit-bot: I haz the power, 2016-08-02 02:31:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 02:31:13]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kozy, 2016-08-02 17:00:37]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-08-02 17:00:39]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 17:02:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 17:08:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 17:08:42]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kozy, 2016-08-02 17:18:21]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 17:19:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-08-02 17:20:28]

lgtm

[kozy, 2016-08-02 17:21:20]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2016-08-02 17:21:24]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-08-02 17:21:24]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2203543002/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2016-08-02 17:21:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 19:37:18]

Description was changed from

==========
[DevTools] Dont pass errorString to async protocol methods

BUG=none
R=dgozman@chromium.org,pfeldman@chromium.org
==========

to

==========
[DevTools] Dont pass errorString to async protocol methods

BUG=none
R=dgozman@chromium.org,pfeldman@chromium.org
==========

[commit-bot: I haz the power, 2016-08-02 19:37:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-02 19:39:54]

Description was changed from

==========
[DevTools] Dont pass errorString to async protocol methods

BUG=none
R=dgozman@chromium.org,pfeldman@chromium.org
==========

to

==========
[DevTools] Dont pass errorString to async protocol methods

BUG=none
R=dgozman@chromium.org,pfeldman@chromium.org

Committed: https://crrev.com/727e8621bd1e32c9d64752fae18175193c9d9db1
Cr-Commit-Position: refs/heads/master@{#409275}
==========

[commit-bot: I haz the power, 2016-08-02 19:39:56]

Patchset 3 (id:??) landed as
https://crrev.com/727e8621bd1e32c9d64752fae18175193c9d9db1
Cr-Commit-Position: refs/heads/master@{#409275}