Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

Issue 2203543002: [DevTools] Dont pass errorString to async protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp
index 172f3de820fb6aef013b73b7c58559904373ddee..a9c0c98914697c39118142c531fbea0ae7e1ab79 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp
@@ -42,7 +42,7 @@ void InspectorTracingAgent::restore()
{
emitMetadataEvents();
}
-void InspectorTracingAgent::start(ErrorString* errorString,
+void InspectorTracingAgent::start(
const Maybe<String>& categories,
const Maybe<String>& options,
const Maybe<double>& bufferUsageReportingInterval,
@@ -52,8 +52,7 @@ void InspectorTracingAgent::start(ErrorString* errorString,
{
ASSERT(sessionId().isEmpty());
if (config.isJust()) {
- *errorString =
- "Using trace config on renderer targets is not supported yet.";
+ callback->sendFailure("Using trace config on renderer targets is not supported yet.");
return;
}
@@ -63,7 +62,7 @@ void InspectorTracingAgent::start(ErrorString* errorString,
callback->sendSuccess();
}
-void InspectorTracingAgent::end(ErrorString* errorString, std::unique_ptr<EndCallback> callback)
+void InspectorTracingAgent::end(std::unique_ptr<EndCallback> callback)
{
m_client->disableTracing();
resetSessionId();

Powered by Google App Engine
This is Rietveld 408576698