Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

Issue 2203543002: [DevTools] Dont pass errorString to async protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 class V8RuntimeAgentImpl : public protocol::Runtime::Backend { 55 class V8RuntimeAgentImpl : public protocol::Runtime::Backend {
56 PROTOCOL_DISALLOW_COPY(V8RuntimeAgentImpl); 56 PROTOCOL_DISALLOW_COPY(V8RuntimeAgentImpl);
57 public: 57 public:
58 V8RuntimeAgentImpl(V8InspectorSessionImpl*, protocol::FrontendChannel*, prot ocol::DictionaryValue* state); 58 V8RuntimeAgentImpl(V8InspectorSessionImpl*, protocol::FrontendChannel*, prot ocol::DictionaryValue* state);
59 ~V8RuntimeAgentImpl() override; 59 ~V8RuntimeAgentImpl() override;
60 void restore(); 60 void restore();
61 61
62 // Part of the protocol. 62 // Part of the protocol.
63 void enable(ErrorString*) override; 63 void enable(ErrorString*) override;
64 void disable(ErrorString*) override; 64 void disable(ErrorString*) override;
65 void evaluate(ErrorString*, 65 void evaluate(
66 const String16& expression, 66 const String16& expression,
67 const Maybe<String16>& objectGroup, 67 const Maybe<String16>& objectGroup,
68 const Maybe<bool>& includeCommandLineAPI, 68 const Maybe<bool>& includeCommandLineAPI,
69 const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole, 69 const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole,
70 const Maybe<int>& executionContextId, 70 const Maybe<int>& executionContextId,
71 const Maybe<bool>& returnByValue, 71 const Maybe<bool>& returnByValue,
72 const Maybe<bool>& generatePreview, 72 const Maybe<bool>& generatePreview,
73 const Maybe<bool>& userGesture, 73 const Maybe<bool>& userGesture,
74 const Maybe<bool>& awaitPromise, 74 const Maybe<bool>& awaitPromise,
75 std::unique_ptr<EvaluateCallback>) override; 75 std::unique_ptr<EvaluateCallback>) override;
76 void awaitPromise(ErrorString*, 76 void awaitPromise(
77 const String16& promiseObjectId, 77 const String16& promiseObjectId,
78 const Maybe<bool>& returnByValue, 78 const Maybe<bool>& returnByValue,
79 const Maybe<bool>& generatePreview, 79 const Maybe<bool>& generatePreview,
80 std::unique_ptr<AwaitPromiseCallback>) override; 80 std::unique_ptr<AwaitPromiseCallback>) override;
81 void callFunctionOn(ErrorString*, 81 void callFunctionOn(ErrorString*,
82 const String16& objectId, 82 const String16& objectId,
83 const String16& expression, 83 const String16& expression,
84 const Maybe<protocol::Array<protocol::Runtime::CallArgument>>& optionalA rguments, 84 const Maybe<protocol::Array<protocol::Runtime::CallArgument>>& optionalA rguments,
85 const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole, 85 const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole,
86 const Maybe<bool>& returnByValue, 86 const Maybe<bool>& returnByValue,
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 protocol::DictionaryValue* m_state; 131 protocol::DictionaryValue* m_state;
132 protocol::Runtime::Frontend m_frontend; 132 protocol::Runtime::Frontend m_frontend;
133 V8InspectorImpl* m_inspector; 133 V8InspectorImpl* m_inspector;
134 bool m_enabled; 134 bool m_enabled;
135 protocol::HashMap<String16, std::unique_ptr<v8::Global<v8::Script>>> m_compi ledScripts; 135 protocol::HashMap<String16, std::unique_ptr<v8::Global<v8::Script>>> m_compi ledScripts;
136 }; 136 };
137 137
138 } // namespace blink 138 } // namespace blink
139 139
140 #endif // V8RuntimeAgentImpl_h 140 #endif // V8RuntimeAgentImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698