third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h - Issue 2203543002: [DevTools] Dont pass errorString to async protocol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h

Issue 2203543002: [DevTools] Dont pass errorString to async protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp ('k') | third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h

diff --git a/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h b/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h

index b8ec23c48c9fedb31511f87ac7bce7d1e9dacf09..8f04e7a64f60956a4102ba984f4750110d360c39 100644

--- a/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h

+++ b/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h

@@ -61,7 +61,7 @@ public:

// Called from the front-end.

void enable(ErrorString*) override;

void getDatabaseTableNames(ErrorString*, const String& databaseId, std::unique_ptr<protocol::Array<String>>* names) override;

- void executeSQL(ErrorString*, const String& databaseId, const String& query, std::unique_ptr<ExecuteSQLCallback>) override;

+ void executeSQL(const String& databaseId, const String& query, std::unique_ptr<ExecuteSQLCallback>) override;

void didOpenDatabase(blink::Database*, const String& domain, const String& name, const String& version);

private: