third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp - Issue 2203543002: [DevTools] Dont pass errorString to async protocol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Issue 2203543002: [DevTools] Dont pass errorString to async protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h ('k') | third_party/WebKit/Source/core/inspector/InspectorPageAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

index f6fef44a73e50c266bc77bb9c52e6373c7e5a500..195ed54a88cfe64de03689944c5f5ec13b0064cd 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

@@ -987,7 +987,7 @@ void InspectorNetworkAgent::getResponseBodyBlob(const String& requestId, std::un

client->start(document);

}

-void InspectorNetworkAgent::getResponseBody(ErrorString* errorString, const String& requestId, std::unique_ptr<GetResponseBodyCallback> passCallback)

+void InspectorNetworkAgent::getResponseBody(const String& requestId, std::unique_ptr<GetResponseBodyCallback> passCallback)

{

std::unique_ptr<GetResponseBodyCallback> callback = std::move(passCallback);

NetworkResourcesData::ResourceData const* resourceData = m_resourcesData->data(requestId);