third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.h - Issue 2203543002: [DevTools] Dont pass errorString to async protocol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.h

Issue 2203543002: [DevTools] Dont pass errorString to async protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp ('k') | third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.h

diff --git a/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.h b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.h

index 868a0b02f8911ca6b877cb739b4fe43c5b3539c8..bc6fb16e0827ce363e16388d854bd68762d46ff0 100644

--- a/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.h

+++ b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.h

@@ -26,10 +26,10 @@ public:

DECLARE_VIRTUAL_TRACE();

- void requestCacheNames(ErrorString*, const String& in_securityOrigin, std::unique_ptr<RequestCacheNamesCallback>) override;

- void requestEntries(ErrorString*, const String& in_cacheId, int in_skipCount, int in_pageSize, std::unique_ptr<RequestEntriesCallback>) override;

- void deleteCache(ErrorString*, const String& in_cacheId, std::unique_ptr<DeleteCacheCallback>) override;

- void deleteEntry(ErrorString*, const String& in_cacheId, const String& in_request, std::unique_ptr<DeleteEntryCallback>) override;

+ void requestCacheNames(const String& securityOrigin, std::unique_ptr<RequestCacheNamesCallback>) override;

+ void requestEntries(const String& cacheId, int skipCount, int pageSize, std::unique_ptr<RequestEntriesCallback>) override;

+ void deleteCache(const String& cacheId, std::unique_ptr<DeleteCacheCallback>) override;

+ void deleteEntry(const String& cacheId, const String& request, std::unique_ptr<DeleteEntryCallback>) override;

private:

explicit InspectorCacheStorageAgent();