third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h - Issue 2203543002: [DevTools] Dont pass errorString to async protocol methods

Side by Side Diff: third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h

Issue 2203543002: [DevTools] Dont pass errorString to async protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 35 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
46 InspectorIndexedDBAgent(InspectedFrames, V8InspectorSession);	46 InspectorIndexedDBAgent(InspectedFrames, V8InspectorSession);

47 ~InspectorIndexedDBAgent() override;	47 ~InspectorIndexedDBAgent() override;

48 DECLARE_VIRTUAL_TRACE();	48 DECLARE_VIRTUAL_TRACE();

49	49

50 void restore() override;	50 void restore() override;

51 void didCommitLoadForLocalFrame(LocalFrame*) override;	51 void didCommitLoadForLocalFrame(LocalFrame*) override;

52	52

53 // Called from the front-end.	53 // Called from the front-end.

54 void enable(ErrorString*) override;	54 void enable(ErrorString*) override;

55 void disable(ErrorString*) override;	55 void disable(ErrorString*) override;

56 void requestDatabaseNames(ErrorString*, const String& securityOrigin, std::u nique_ptr<RequestDatabaseNamesCallback>) override;	56 void requestDatabaseNames(const String& securityOrigin, std::unique_ptr<Requ estDatabaseNamesCallback>) override;

57 void requestDatabase(ErrorString*, const String& securityOrigin, const Strin g& databaseName, std::unique_ptr<RequestDatabaseCallback>) override;	57 void requestDatabase(const String& securityOrigin, const String& databaseNam e, std::unique_ptr<RequestDatabaseCallback>) override;

58 void requestData(ErrorString*, const String& securityOrigin, const String& d atabaseName, const String& objectStoreName, const String& indexName, int skipCou nt, int pageSize, const Maybe<protocol::IndexedDB::KeyRange>&, std::unique_ptr<R equestDataCallback>) override;	58 void requestData(const String& securityOrigin, const String& databaseName, c onst String& objectStoreName, const String& indexName, int skipCount, int pageSi ze, const Maybe<protocol::IndexedDB::KeyRange>&, std::unique_ptr<RequestDataCall back>) override;

59 void clearObjectStore(ErrorString*, const String& securityOrigin, const Stri ng& databaseName, const String& objectStoreName, std::unique_ptr<ClearObjectStor eCallback>) override;	59 void clearObjectStore(const String& securityOrigin, const String& databaseNa me, const String& objectStoreName, std::unique_ptr<ClearObjectStoreCallback>) ov erride;

60	60

61 private:	61 private:

62 Member<InspectedFrames> m_inspectedFrames;	62 Member<InspectedFrames> m_inspectedFrames;

63 V8InspectorSession* m_v8Session;	63 V8InspectorSession* m_v8Session;

64 };	64 };

65	65

66 } // namespace blink	66 } // namespace blink

67	67

68 #endif // !defined(InspectorIndexedDBAgent_h)	68 #endif // !defined(InspectorIndexedDBAgent_h)

OLD	NEW