third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h - Issue 2203543002: [DevTools] Dont pass errorString to async protocol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

Issue 2203543002: [DevTools] Dont pass errorString to async protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

index 049f709ab4ab54d4e424bcbf41f49883b535e58a..7d1a22c49827c8b1ac4d2d499daf95aaa7813d11 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

@@ -62,7 +62,7 @@ public:

// Part of the protocol.

void enable(ErrorString*) override;

void disable(ErrorString*) override;

- void evaluate(ErrorString*,

+ void evaluate(

const String16& expression,

const Maybe<String16>& objectGroup,

const Maybe<bool>& includeCommandLineAPI,

@@ -73,7 +73,7 @@ public:

const Maybe<bool>& userGesture,

const Maybe<bool>& awaitPromise,

std::unique_ptr<EvaluateCallback>) override;

- void awaitPromise(ErrorString*,

+ void awaitPromise(

const String16& promiseObjectId,

const Maybe<bool>& returnByValue,

const Maybe<bool>& generatePreview,