[DevTools] Add awaitPromise flag for Runtime.callFunctionOn protocol method

[DevTools] Add awaitPromise flag for Runtime.callFunctionOn protocol method

- added awaitPromise flag,
- added exceptionDetails to align this method with Runtime.evaluate.

BUG=632875
R=dgozman@chromium.org

Committed: https://crrev.com/df84ce474a9ce3b192e2243c72d24ac3dc408beb
Cr-Commit-Position: refs/heads/master@{#409328}

[kozy, 2016-08-02 02:28:42]

Dmitry, please take a look!

[dgozman, 2016-08-02 16:52:51]

lgtm

https://codereview.chromium.org/2206483002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/2206483002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:68: if
(!value->IsPromise()) {
Since you already do this check in 2 out of 3 methods manually, let's move it to
the last one, and pass v8::Local<v8::Promise> here.

https://codereview.chromium.org/2206483002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:394:
callback->sendFailure("Result of expression is not a promise.");
Result of the function call is not a promise.

[kozy, 2016-08-02 17:31:38]

All done.

https://codereview.chromium.org/2206483002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/2206483002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:68: if
(!value->IsPromise()) {
On 2016/08/02 16:52:51, dgozman wrote:
> Since you already do this check in 2 out of 3 methods manually, let's move it
to
> the last one, and pass v8::Local<v8::Promise> here.

Done.

https://codereview.chromium.org/2206483002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:394:
callback->sendFailure("Result of expression is not a promise.");
On 2016/08/02 16:52:51, dgozman wrote:
> Result of the function call is not a promise.

Done.

[kozy, 2016-08-02 19:39:12]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 19:39:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 21:18:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 21:18:33]

Dry run: This issue passed the CQ dry run.

[kozy, 2016-08-02 21:24:52]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-08-02 21:24:52]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2206483002/#ps20001
(title: "rebased")

[commit-bot: I haz the power, 2016-08-02 21:25:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 21:30:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-02 21:36:41]

Description was changed from

==========
[DevTools] Add awaitPromise flag for Runtime.callFunctionOn protocol method

- added awaitPromise flag,
- added exceptionDetails to align this method with Runtime.evaluate.

BUG=632875
R=dgozman@chromium.org
==========

to

==========
[DevTools] Add awaitPromise flag for Runtime.callFunctionOn protocol method

- added awaitPromise flag,
- added exceptionDetails to align this method with Runtime.evaluate.

BUG=632875
R=dgozman@chromium.org

Committed: https://crrev.com/df84ce474a9ce3b192e2243c72d24ac3dc408beb
Cr-Commit-Position: refs/heads/master@{#409328}
==========

[commit-bot: I haz the power, 2016-08-02 21:36:42]

Patchset 2 (id:??) landed as
https://crrev.com/df84ce474a9ce3b192e2243c72d24ac3dc408beb
Cr-Commit-Position: refs/heads/master@{#409328}