Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2206483002: [DevTools] Add awaitPromise flag for Runtime.callFunctionOn protocol method (Closed)

Created:
4 years, 4 months ago by kozy
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-error-string-from-async
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Add awaitPromise flag for Runtime.callFunctionOn protocol method - added awaitPromise flag, - added exceptionDetails to align this method with Runtime.evaluate. BUG=632875 R=dgozman@chromium.org Committed: https://crrev.com/df84ce474a9ce3b192e2243c72d24ac3dc408beb Cr-Commit-Position: refs/heads/master@{#409328}

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebased #

Messages

Total messages: 13 (7 generated)
kozy
Dmitry, please take a look!
4 years, 4 months ago (2016-08-02 02:28:42 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2206483002/diff/1/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp (right): https://codereview.chromium.org/2206483002/diff/1/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp#newcode68 third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:68: if (!value->IsPromise()) { Since you already do this ...
4 years, 4 months ago (2016-08-02 16:52:51 UTC) #2
kozy
All done. https://codereview.chromium.org/2206483002/diff/1/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp (right): https://codereview.chromium.org/2206483002/diff/1/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp#newcode68 third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:68: if (!value->IsPromise()) { On 2016/08/02 16:52:51, dgozman ...
4 years, 4 months ago (2016-08-02 17:31:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206483002/20001
4 years, 4 months ago (2016-08-02 21:25:36 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 21:30:58 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 21:36:42 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/df84ce474a9ce3b192e2243c72d24ac3dc408beb
Cr-Commit-Position: refs/heads/master@{#409328}

Powered by Google App Engine
This is Rietveld 408576698