Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h

Issue 2203543002: [DevTools] Dont pass errorString to async protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 ~InspectorDatabaseAgent() override; 54 ~InspectorDatabaseAgent() override;
55 DECLARE_VIRTUAL_TRACE(); 55 DECLARE_VIRTUAL_TRACE();
56 56
57 void disable(ErrorString*) override; 57 void disable(ErrorString*) override;
58 void restore() override; 58 void restore() override;
59 void didCommitLoadForLocalFrame(LocalFrame*) override; 59 void didCommitLoadForLocalFrame(LocalFrame*) override;
60 60
61 // Called from the front-end. 61 // Called from the front-end.
62 void enable(ErrorString*) override; 62 void enable(ErrorString*) override;
63 void getDatabaseTableNames(ErrorString*, const String& databaseId, std::uniq ue_ptr<protocol::Array<String>>* names) override; 63 void getDatabaseTableNames(ErrorString*, const String& databaseId, std::uniq ue_ptr<protocol::Array<String>>* names) override;
64 void executeSQL(ErrorString*, const String& databaseId, const String& query, std::unique_ptr<ExecuteSQLCallback>) override; 64 void executeSQL(const String& databaseId, const String& query, std::unique_p tr<ExecuteSQLCallback>) override;
65 65
66 void didOpenDatabase(blink::Database*, const String& domain, const String& n ame, const String& version); 66 void didOpenDatabase(blink::Database*, const String& domain, const String& n ame, const String& version);
67 private: 67 private:
68 explicit InspectorDatabaseAgent(Page*); 68 explicit InspectorDatabaseAgent(Page*);
69 void registerDatabaseOnCreation(blink::Database*); 69 void registerDatabaseOnCreation(blink::Database*);
70 70
71 blink::Database* databaseForId(const String& databaseId); 71 blink::Database* databaseForId(const String& databaseId);
72 InspectorDatabaseResource* findByFileName(const String& fileName); 72 InspectorDatabaseResource* findByFileName(const String& fileName);
73 73
74 Member<Page> m_page; 74 Member<Page> m_page;
75 typedef HeapHashMap<String, Member<InspectorDatabaseResource>> DatabaseResou rcesHeapMap; 75 typedef HeapHashMap<String, Member<InspectorDatabaseResource>> DatabaseResou rcesHeapMap;
76 DatabaseResourcesHeapMap m_resources; 76 DatabaseResourcesHeapMap m_resources;
77 bool m_enabled; 77 bool m_enabled;
78 }; 78 };
79 79
80 } // namespace blink 80 } // namespace blink
81 81
82 #endif // !defined(InspectorDatabaseAgent_h) 82 #endif // !defined(InspectorDatabaseAgent_h)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698