third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h - Issue 2203543002: [DevTools] Dont pass errorString to async protocol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h

Issue 2203543002: [DevTools] Dont pass errorString to async protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h

index 0d338a14f70b91715abcdddc46433f5d056ebb91..a4a1011a76cef3540167c6e68d04ab77f5110252 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h

@@ -41,8 +41,8 @@ public:

void disable(ErrorString*) override;

// Protocol method implementations.

- void start(ErrorString*, const Maybe<String>& categories, const Maybe<String>& options, const Maybe<double>& bufferUsageReportingInterval, const Maybe<String>& transferMode, const Maybe<protocol::Tracing::TraceConfig>&, std::unique_ptr<StartCallback>) override;

- void end(ErrorString*, std::unique_ptr<EndCallback>) override;

+ void start(const Maybe<String>& categories, const Maybe<String>& options, const Maybe<double>& bufferUsageReportingInterval, const Maybe<String>& transferMode, const Maybe<protocol::Tracing::TraceConfig>&, std::unique_ptr<StartCallback>) override;

+ void end(std::unique_ptr<EndCallback>) override;

// Methods for other agents to use.

void setLayerTreeId(int);