[Findit] Refactor Findit pipeline.

[Findit] Refactor Findit pipeline.

1. Merge pipelines under the same root pipeline and remove some unused pipelines
2. For test try jobs, trigger swarming tasks earlier 

Example try jobs after this refactor:
Compile: 
https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Builder/builds/26425

Test:
https://findit-for-me.appspot.com/waterfall/failure?url=https://luci-milo.appspot.com/buildbot/chromium.mac/Mac10.11%20Tests/10502

Design doc (Under development): 
https://docs.google.com/a/google.com/document/d/1QzkpoJT_XrN0cwMXPYjDMXpJfNNYH7-rFFhSaCV7RjY/edit?usp=sharing

BUG=632121, 627298
Committed: https://chromium.googlesource.com/infra/infra/+/41875d7adbe20d8c9adeaaa7b47000cc8804d5d1

[chanli, 2016-07-27 20:28:32]

Description was changed from

==========
[Findit] Refactor Findit pipeline.

BUG=632121, 627298
==========

to

==========
[Findit] Refactor Findit pipeline.

1. Merge pipelines under the same root pipeline and remove some unused pipelines
2. For test try jobs, trigger swarming tasks earlier 

Example try jobs after this refactor:
Compile: 
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Test:
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Design doc (Under development): 
https://docs.google.com/a/google.com/document/d/1QzkpoJT_XrN0cwMXPYjDMXpJfNNY...

BUG=632121, 627298
==========

[chanli, 2016-07-27 20:28:55]

Description was changed from

==========
[Findit] Refactor Findit pipeline.

1. Merge pipelines under the same root pipeline and remove some unused pipelines
2. For test try jobs, trigger swarming tasks earlier 

Example try jobs after this refactor:
Compile: 
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Test:
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Design doc (Under development): 
https://docs.google.com/a/google.com/document/d/1QzkpoJT_XrN0cwMXPYjDMXpJfNNY...

BUG=632121, 627298
==========

to

==========
[Findit] Refactor Findit pipeline.

1. Merge pipelines under the same root pipeline and remove some unused pipelines
2. For test try jobs, trigger swarming tasks earlier 

Example try jobs after this refactor:
Compile: 
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Test:
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Design doc (Under development): 
https://docs.google.com/a/google.com/document/d/1QzkpoJT_XrN0cwMXPYjDMXpJfNNY...

BUG=632121, 627298
==========

[chanli, 2016-07-27 20:30:06]

chanli@chromium.org changed reviewers:
+ katesonia@chromium.org, lijeffrey@chromium.org

[chanli, 2016-07-27 20:30:07]

PTAL.

[chanli, 2016-07-27 20:52:52]

PTAL...

[chromium-reviews, 2016-07-27 23:09:11]

This is a huge cl...

On Wed, Jul 27, 2016 at 1:52 PM, <chanli@chromium.org> wrote:

> PTAL...
>
> https://codereview.chromium.org/2187763004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chanli, 2016-08-02 00:07:17]

On 2016/07/27 23:09:11, chromium-reviews wrote:
> This is a huge cl...
> 
> On Wed, Jul 27, 2016 at 1:52 PM, <mailto:chanli@chromium.org> wrote:
> 
> > PTAL...
> >
> > https://codereview.chromium.org/2187763004/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Ping : )

[Sharu Jiang, 2016-08-04 06:21:12]

Just reviewed schedule_compile_try_job_pipeline, schedule_test_try_job_pipeline
and their tests.

Will review others files later :)

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/schedule_compile_try_job_pipeline.py (right):

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/schedule_compile_try_job_pipeline.py:1: # Copyright
2016 The Chromium Authors. All rights reserved.
I think that 'schedule_compile_try_job_pipeline' and
'shedule_test_try_job_pipeline' are very duplicate.

How about pass a type enum to a single pipeline? so we can avoid duplication.

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/schedule_compile_try_job_pipeline.py:16: properties =
super(ScheduleCompileTryJobPipeline, self)._GetBuildProperties(
Why not just use self._GetBuildProperties? it's already inherited from
ScheduleTryJobPipeline.

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/schedule_test_try_job_pipeline.py (right):

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/schedule_test_try_job_pipeline.py:45: targeted_tests
= _GetTargetedTests(dict(reliable_tests))
In the test, the dummy reliable_tests is ['a on platform', ['a', ['test1',
'test2']]]

so when we pass this to 

def run(..., *reliable_tests):
  ...

The reliable_tests would be converted to a tuple (['a on platform', ['a',
['test1', 'test2']]], ) inside function, if we convert this tuple to dict, that
would throw exception.

I don't think this is the intended behavior? Or is there special rule for
pipeline run *args ?

[lijeffrey, 2016-08-04 10:31:47]

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/analyze_build_failure_pipeline.py (right):

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/analyze_build_failure_pipeline.py:74: # Heuristic
Approach
nit: . after comment

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/schedule_compile_try_job_pipeline.py (right):

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/schedule_compile_try_job_pipeline.py:26:
bad_revision, try_job_type, compile_targets, suspected_revisions):
so since this is for compile only, do we still need try_job_type? Same with
schedule_test_try_job_pipeline

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/start_try_job_on_demand_pipeline.py (right):

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/start_try_job_on_demand_pipeline.py:48:
suspected_revisions = set()
nit: why not check heuristic_result first and return [] if it's empty?

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/start_try_job_on_demand_pipeline.py:97: else:  #
try_job_type == failure_type.TEST.
nit: should this be removed?

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py
(right):

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py:20:
def _MockGetChangeLog(self, revision):
should the empty line be kept?

[chanli, 2016-08-05 19:53:54]

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/analyze_build_failure_pipeline.py (right):

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/analyze_build_failure_pipeline.py:74: # Heuristic
Approach
On 2016/08/04 10:31:47, lijeffrey wrote:
> nit: . after comment

Done.

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/schedule_compile_try_job_pipeline.py (right):

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/schedule_compile_try_job_pipeline.py:1: # Copyright
2016 The Chromium Authors. All rights reserved.
On 2016/08/04 06:21:12, sharu jiang wrote:
> I think that 'schedule_compile_try_job_pipeline' and
> 'shedule_test_try_job_pipeline' are very duplicate.
> 
> How about pass a type enum to a single pipeline? so we can avoid duplication.

They are not duplicates, in fact I have ScheduleTryJobPipeline as the base class
and they inherit from it.

Separating compile and test try jobs are in the plan of refactoring.

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/schedule_compile_try_job_pipeline.py:16: properties =
super(ScheduleCompileTryJobPipeline, self)._GetBuildProperties(
On 2016/08/04 06:21:12, sharu jiang wrote:
> Why not just use self._GetBuildProperties? it's already inherited from
> ScheduleTryJobPipeline. 

I'm not sure if I understand you... I need to add additional property for
compile only

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/schedule_compile_try_job_pipeline.py:26:
bad_revision, try_job_type, compile_targets, suspected_revisions):
On 2016/08/04 10:31:47, lijeffrey wrote:
> so since this is for compile only, do we still need try_job_type? Same with
> schedule_test_try_job_pipeline

we need try_job_type to choose the recipe in _GetBuildProperties. Although we
can also use a constant to do that...

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/schedule_test_try_job_pipeline.py (right):

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/schedule_test_try_job_pipeline.py:45: targeted_tests
= _GetTargetedTests(dict(reliable_tests))
On 2016/08/04 06:21:12, sharu jiang wrote:
> In the test, the dummy reliable_tests is ['a on platform', ['a', ['test1',
> 'test2']]]
> 
> so when we pass this to 
> 
> def run(..., *reliable_tests):
>   ...
> 
> The reliable_tests would be converted to a tuple (['a on platform', ['a',
> ['test1', 'test2']]], ) inside function, if we convert this tuple to dict,
that
> would throw exception.
> 
> I don't think this is the intended behavior? Or is there special rule for
> pipeline run *args ?

Yes. use *args each element in the list will be treated like an arg.

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/start_try_job_on_demand_pipeline.py (right):

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/start_try_job_on_demand_pipeline.py:48:
suspected_revisions = set()
On 2016/08/04 10:31:47, lijeffrey wrote:
> nit: why not check heuristic_result first and return [] if it's empty?

Done.

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/start_try_job_on_demand_pipeline.py:97: else:  #
try_job_type == failure_type.TEST.
On 2016/08/04 10:31:47, lijeffrey wrote:
> nit: should this be removed?

Done.

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py
(right):

https://codereview.chromium.org/2187763004/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py:20:
def _MockGetChangeLog(self, revision):
On 2016/08/04 10:31:47, lijeffrey wrote:
> should the empty line be kept?

Done.

[lijeffrey, 2016-08-09 04:07:34]

https://codereview.chromium.org/2187763004/diff/40001/appengine/findit/waterf...
File appengine/findit/waterfall/start_try_job_on_demand_pipeline.py (right):

https://codereview.chromium.org/2187763004/diff/40001/appengine/findit/waterf...
appengine/findit/waterfall/start_try_job_on_demand_pipeline.py:78:
logging.warning('Couldn"t start try job because last_pass is not found.')
is this a normal scenario that last pass is unavailable? If it's not supposed to
happen, should we change this to logging.error and include master_name,
builder_name, build_number?

https://codereview.chromium.org/2187763004/diff/40001/appengine/findit/waterf...
appengine/findit/waterfall/start_try_job_on_demand_pipeline.py:106: for
test_failure in step_failure['tests'].itervalues():
I would break this part into a separate helper method to determine whether or
not a first time failure can be found

def _HasFirstTimeFailure(tests, build_number):
  ...


step_has_first_time_failure = _HasFirstTimeFailure(step_failure['tests'],
build_number)

This would make the code cleaner and more testable

https://codereview.chromium.org/2187763004/diff/40001/appengine/findit/waterf...
File appengine/findit/waterfall/try_job_util.py (right):

https://codereview.chromium.org/2187763004/diff/40001/appengine/findit/waterf...
appengine/findit/waterfall/try_job_util.py:246: def _NeedANewTryJobForCompile(
nit: how about _NeedANewCompileTryJob/_NeedANewTestTryJob?

https://codereview.chromium.org/2187763004/diff/40001/appengine/findit/waterf...
appengine/findit/waterfall/try_job_util.py:268: if
waterfall_config.ShouldSkipTestTryJobs(master_name, builder_name):
nit: It looks like these if statements can be combined into an and

https://codereview.chromium.org/2187763004/diff/40001/appengine/findit/waterf...
appengine/findit/waterfall/try_job_util.py:274: failure_result_map =
analysis.failure_result_map
nit: break this part of the code into a separate function like
_CurrentBuildKeyInFailureResultMap(analysis) (or master_name, builder_name,
build_number) or something to make the functions easier to test

[chanli, 2016-08-09 17:08:43]

https://codereview.chromium.org/2187763004/diff/40001/appengine/findit/waterf...
File appengine/findit/waterfall/start_try_job_on_demand_pipeline.py (right):

https://codereview.chromium.org/2187763004/diff/40001/appengine/findit/waterf...
appengine/findit/waterfall/start_try_job_on_demand_pipeline.py:78:
logging.warning('Couldn"t start try job because last_pass is not found.')
On 2016/08/09 04:07:34, lijeffrey wrote:
> is this a normal scenario that last pass is unavailable? If it's not supposed
to
> happen, should we change this to logging.error and include master_name,
> builder_name, build_number?

There are some cases:
1. If a failure has happened on more than 20 consecutive builds
2. If the builder is newly added 
3. There is something wrong

I'm not sure if we should escalate this to error. But you're write we should add
build info to the message.

https://codereview.chromium.org/2187763004/diff/40001/appengine/findit/waterf...
appengine/findit/waterfall/start_try_job_on_demand_pipeline.py:106: for
test_failure in step_failure['tests'].itervalues():
On 2016/08/09 04:07:34, lijeffrey wrote:
> I would break this part into a separate helper method to determine whether or
> not a first time failure can be found
> 
> def _HasFirstTimeFailure(tests, build_number):
>   ...
> 
> 
> step_has_first_time_failure = _HasFirstTimeFailure(step_failure['tests'],
> build_number)
> 
> This would make the code cleaner and more testable
> 

Done.

https://codereview.chromium.org/2187763004/diff/40001/appengine/findit/waterf...
File appengine/findit/waterfall/try_job_util.py (right):

https://codereview.chromium.org/2187763004/diff/40001/appengine/findit/waterf...
appengine/findit/waterfall/try_job_util.py:246: def _NeedANewTryJobForCompile(
On 2016/08/09 04:07:34, lijeffrey wrote:
> nit: how about _NeedANewCompileTryJob/_NeedANewTestTryJob?

Done.

https://codereview.chromium.org/2187763004/diff/40001/appengine/findit/waterf...
appengine/findit/waterfall/try_job_util.py:268: if
waterfall_config.ShouldSkipTestTryJobs(master_name, builder_name):
On 2016/08/09 04:07:34, lijeffrey wrote:
> nit: It looks like these if statements can be combined into an and

Done.

https://codereview.chromium.org/2187763004/diff/40001/appengine/findit/waterf...
appengine/findit/waterfall/try_job_util.py:274: failure_result_map =
analysis.failure_result_map
On 2016/08/09 04:07:34, lijeffrey wrote:
> nit: break this part of the code into a separate function like
> _CurrentBuildKeyInFailureResultMap(analysis) (or master_name, builder_name,
> build_number) or something to make the functions easier to test

Done.

[lijeffrey, 2016-08-09 22:30:07]

lgtm

[Sharu Jiang, 2016-08-09 22:31:31]

lgtm

[Sharu Jiang, 2016-08-09 23:05:04]

https://codereview.chromium.org/2187763004/diff/60001/appengine/findit/waterf...
File appengine/findit/waterfall/schedule_compile_try_job_pipeline.py (right):

https://codereview.chromium.org/2187763004/diff/60001/appengine/findit/waterf...
appengine/findit/waterfall/schedule_compile_try_job_pipeline.py:26:
bad_revision, try_job_type, compile_targets, suspected_revisions):
nit: Add doc string to explain parameters because the old function did :)

https://codereview.chromium.org/2187763004/diff/60001/appengine/findit/waterf...
File appengine/findit/waterfall/schedule_test_try_job_pipeline.py (right):

https://codereview.chromium.org/2187763004/diff/60001/appengine/findit/waterf...
appengine/findit/waterfall/schedule_test_try_job_pipeline.py:39: bad_revision,
try_job_type, suspected_revisions, *reliable_tests):
nit: Add doc string to explain parameters

[Sharu Jiang, 2016-08-09 23:22:15]

https://codereview.chromium.org/2187763004/diff/60001/appengine/findit/waterf...
File appengine/findit/waterfall/test/schedule_test_try_job_pipeline_test.py
(right):

https://codereview.chromium.org/2187763004/diff/60001/appengine/findit/waterf...
appengine/findit/waterfall/test/schedule_test_try_job_pipeline_test.py:60:
targeted_tests = ['a on platform', ['a', ['test1', 'test2']]]
If there are multiply platforms:

targeted_tests = [('a on platform1', ['a', ['test1', 'test2']]),
                  ('a on platform2', ['a', ['test3', 'test4']])]

try_job_id = try_job_pipeline.run(
    master_name, builder_name, build_number, good_revision, bad_revision,
    failure_type.TEST, None, *targeted_tests)

Is this correct?

[chanli, 2016-08-11 01:27:54]

https://codereview.chromium.org/2187763004/diff/60001/appengine/findit/waterf...
File appengine/findit/waterfall/schedule_compile_try_job_pipeline.py (right):

https://codereview.chromium.org/2187763004/diff/60001/appengine/findit/waterf...
appengine/findit/waterfall/schedule_compile_try_job_pipeline.py:26:
bad_revision, try_job_type, compile_targets, suspected_revisions):
On 2016/08/09 23:05:04, sharu jiang wrote:
> nit: Add doc string to explain parameters because the old function did :)

Done.

https://codereview.chromium.org/2187763004/diff/60001/appengine/findit/waterf...
File appengine/findit/waterfall/schedule_test_try_job_pipeline.py (right):

https://codereview.chromium.org/2187763004/diff/60001/appengine/findit/waterf...
appengine/findit/waterfall/schedule_test_try_job_pipeline.py:39: bad_revision,
try_job_type, suspected_revisions, *reliable_tests):
On 2016/08/09 23:05:04, sharu jiang wrote:
> nit: Add doc string to explain parameters

Done.

https://codereview.chromium.org/2187763004/diff/60001/appengine/findit/waterf...
File appengine/findit/waterfall/test/schedule_test_try_job_pipeline_test.py
(right):

https://codereview.chromium.org/2187763004/diff/60001/appengine/findit/waterf...
appengine/findit/waterfall/test/schedule_test_try_job_pipeline_test.py:60:
targeted_tests = ['a on platform', ['a', ['test1', 'test2']]]
On 2016/08/09 23:22:15, sharu jiang wrote:
> If there are multiply platforms:
> 
> targeted_tests = [('a on platform1', ['a', ['test1', 'test2']]),
>                   ('a on platform2', ['a', ['test3', 'test4']])]
> 
> try_job_id = try_job_pipeline.run(
>     master_name, builder_name, build_number, good_revision, bad_revision,
>     failure_type.TEST, None, *targeted_tests)
> 
> Is this correct?

No. In test we are only testing this pipeline so we just pass the targeted tests
directly. But when the pipeline is actually running, reliable_tests are a list
of futures from last pipeline.

[Sharu Jiang, 2016-08-11 17:57:39]

lgtm

[chanli, 2016-08-12 17:28:41]

The CQ bit was checked by chanli@chromium.org

[chanli, 2016-08-12 17:28:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
lijeffrey@chromium.org
Link to the patchset: https://codereview.chromium.org/2187763004/#ps80001
(title: ".")

[commit-bot: I haz the power, 2016-08-12 17:28:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 17:30:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 17:30:41]

Try jobs failed on following builders:
  Infra Linux Precise 32 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30989e4a920bcc10)
  Infra Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30989e4d4b8a7110)
  Infra Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30989e4aa1e65410)

[chanli, 2016-08-12 17:34:30]

The CQ bit was checked by chanli@chromium.org

[chanli, 2016-08-12 17:34:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
katesonia@chromium.org, lijeffrey@chromium.org
Link to the patchset: https://codereview.chromium.org/2187763004/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-12 17:34:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 17:47:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 17:47:07]

Try jobs failed on following builders:
  Infra Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3098a96911c6a610)

[chanli, 2016-08-12 23:06:21]

The CQ bit was checked by chanli@chromium.org

[chanli, 2016-08-12 23:06:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
katesonia@chromium.org, lijeffrey@chromium.org
Link to the patchset: https://codereview.chromium.org/2187763004/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-12 23:06:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 23:23:38]

Description was changed from

==========
[Findit] Refactor Findit pipeline.

1. Merge pipelines under the same root pipeline and remove some unused pipelines
2. For test try jobs, trigger swarming tasks earlier 

Example try jobs after this refactor:
Compile: 
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Test:
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Design doc (Under development): 
https://docs.google.com/a/google.com/document/d/1QzkpoJT_XrN0cwMXPYjDMXpJfNNY...

BUG=632121, 627298
==========

to

==========
[Findit] Refactor Findit pipeline.

1. Merge pipelines under the same root pipeline and remove some unused pipelines
2. For test try jobs, trigger swarming tasks earlier 

Example try jobs after this refactor:
Compile: 
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Test:
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Design doc (Under development): 
https://docs.google.com/a/google.com/document/d/1QzkpoJT_XrN0cwMXPYjDMXpJfNNY...

BUG=632121, 627298

Committed:
https://chromium.googlesource.com/infra/infra/+/41875d7adbe20d8c9adeaaa7b4700...
==========

[commit-bot: I haz the power, 2016-08-12 23:23:39]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/infra/infra/+/41875d7adbe20d8c9adeaaa7b4700...

[chanli1, 2017-04-07 18:34:11]

Description was changed from

==========
[Findit] Refactor Findit pipeline.

1. Merge pipelines under the same root pipeline and remove some unused pipelines
2. For test try jobs, trigger swarming tasks earlier 

Example try jobs after this refactor:
Compile: 
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Test:
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Design doc (Under development): 
https://docs.google.com/a/google.com/document/d/1QzkpoJT_XrN0cwMXPYjDMXpJfNNY...

BUG=632121, 627298

Committed:
https://chromium.googlesource.com/infra/infra/+/41875d7adbe20d8c9adeaaa7b4700...
==========

to

==========
[Findit] Refactor Findit pipeline.

1. Merge pipelines under the same root pipeline and remove some unused pipelines
2. For test try jobs, trigger swarming tasks earlier 

Example try jobs after this refactor:
Compile: 
https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.c...

Test:
https://findit-for-me.appspot.com/waterfall/failure?url=https://luci-milo.app...

Design doc (Under development): 
https://docs.google.com/a/google.com/document/d/1QzkpoJT_XrN0cwMXPYjDMXpJfNNY...

BUG=632121, 627298

Committed:
https://chromium.googlesource.com/infra/infra/+/41875d7adbe20d8c9adeaaa7b4700...
==========