[Findit] Use new mock for unittests.

[Findit] Use new mock for unittests.

BUG=

Committed: https://chromium.googlesource.com/infra/infra/+/aa588f1b897fe161bf2b9b9850072adca0142e7b

[chanli, 2016-08-02 00:06:08]

chanli@chromium.org changed reviewers:
+ katesonia@chromium.org, lijeffrey@chromium.org

[chanli, 2016-08-02 00:06:09]

PTAL

[lijeffrey, 2016-08-02 21:37:09]

lgtm with nits

https://codereview.chromium.org/2203643002/diff/1/appengine/findit/handlers/m...
File appengine/findit/handlers/monitor_alerts.py (right):

https://codereview.chromium.org/2203643002/diff/1/appengine/findit/handlers/m...
appengine/findit/handlers/monitor_alerts.py:88: print build_failures
remove this before committing

https://codereview.chromium.org/2203643002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py (right):

https://codereview.chromium.org/2203643002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py:243: #         
  buildbucket_client.BuildbucketError(build_error['error']), None))
should this be removed?

[lijeffrey, 2016-08-02 21:37:09]

lgtm with nits

https://codereview.chromium.org/2203643002/diff/1/appengine/findit/handlers/m...
File appengine/findit/handlers/monitor_alerts.py (right):

https://codereview.chromium.org/2203643002/diff/1/appengine/findit/handlers/m...
appengine/findit/handlers/monitor_alerts.py:88: print build_failures
remove this before committing

https://codereview.chromium.org/2203643002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py (right):

https://codereview.chromium.org/2203643002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py:243: #         
  buildbucket_client.BuildbucketError(build_error['error']), None))
should this be removed?

[Sharu Jiang, 2016-08-02 22:27:16]

lgtm with a nit question

https://codereview.chromium.org/2203643002/diff/1/appengine/findit/handlers/t...
File appengine/findit/handlers/test/monitor_alerts_test.py (right):

https://codereview.chromium.org/2203643002/diff/1/appengine/findit/handlers/t...
appengine/findit/handlers/test/monitor_alerts_test.py:151: def
testAnalysisScheduled(self, mock_other, mock_fn):
The mock_other seems a little confusing to me... what does 'other' mean?
How about mock_pipeline or mock_module?

[chanli, 2016-08-02 23:10:33]

https://codereview.chromium.org/2203643002/diff/1/appengine/findit/handlers/m...
File appengine/findit/handlers/monitor_alerts.py (right):

https://codereview.chromium.org/2203643002/diff/1/appengine/findit/handlers/m...
appengine/findit/handlers/monitor_alerts.py:88: print build_failures
On 2016/08/02 21:37:09, lijeffrey wrote:
> remove this before committing

Done.

https://codereview.chromium.org/2203643002/diff/1/appengine/findit/handlers/t...
File appengine/findit/handlers/test/monitor_alerts_test.py (right):

https://codereview.chromium.org/2203643002/diff/1/appengine/findit/handlers/t...
appengine/findit/handlers/test/monitor_alerts_test.py:151: def
testAnalysisScheduled(self, mock_other, mock_fn):
On 2016/08/02 22:27:16, sharu jiang wrote:
> The mock_other seems a little confusing to me... what does 'other' mean?
> How about mock_pipeline or mock_module?

Done.

https://codereview.chromium.org/2203643002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py (right):

https://codereview.chromium.org/2203643002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py:243: #         
  buildbucket_client.BuildbucketError(build_error['error']), None))
On 2016/08/02 21:37:09, lijeffrey wrote:
> should this be removed?

Done.

[lijeffrey, 2016-08-02 23:15:56]

lgtm

[chanli, 2016-08-22 18:04:10]

The CQ bit was checked by chanli@chromium.org

[chanli, 2016-08-22 18:04:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
katesonia@chromium.org, lijeffrey@chromium.org
Link to the patchset: https://codereview.chromium.org/2203643002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-22 18:04:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 18:30:54]

Description was changed from

==========
[Findit] Use new mock for unittests.

BUG=
==========

to

==========
[Findit] Use new mock for unittests.

BUG=

Committed:
https://chromium.googlesource.com/infra/infra/+/aa588f1b897fe161bf2b9b9850072...
==========

[commit-bot: I haz the power, 2016-08-22 18:30:55]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/aa588f1b897fe161bf2b9b9850072...