[Findit] Refactor Findit pipeline.

appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
 import json
 import time
 
 from common.waterfall import buildbucket_client
+from common.waterfall import failure_type
 from common.waterfall import try_job_error
 from model import analysis_status
 from model.wf_try_job import WfTryJob
 from model.wf_try_job_data import WfTryJobData
 from waterfall import monitor_try_job_pipeline
 from waterfall import waterfall_config
 from waterfall.monitor_try_job_pipeline import MonitorTryJobPipeline
 from waterfall.test import wf_testcase
-from waterfall.try_job_type import TryJobType
 
 
 # A counter to enable different responses to requests in a loop.
 REQUEST_COUNTER = {
     '1': 0,
     '2': 0,
     '3': 0
 }
 
 
@@ skipping 180 matching lines @@
             'url': 'url',
             'try_job_id': '1',
         }
     ]
     try_job.status = analysis_status.RUNNING
     try_job.put()
     self._MockGetTryJobs(try_job_id)
 
     pipeline = MonitorTryJobPipeline()
     compile_result = pipeline.run(
-        master_name, builder_name, build_number, TryJobType.COMPILE,
+        master_name, builder_name, build_number, failure_type.COMPILE,
         try_job_id)
 
     expected_compile_result = {
         'report': {
             'result': {
                 'rev1': 'passed',
                 'rev2': 'failed'
             },
             'metadata': {
                 'regression_range_size': regression_range_size
@@ skipping 29 matching lines @@
     try_job.status = analysis_status.RUNNING
     try_job.put()
 
     try_job_data = WfTryJobData.Create(try_job_id)
     try_job_data.put()
 
     self._MockGetTryJobs(try_job_id)
 
     pipeline = MonitorTryJobPipeline()
     test_result = pipeline.run(
-        master_name, builder_name, build_number, TryJobType.TEST,
+        master_name, builder_name, build_number, failure_type.TEST,
         try_job_id)
 
     expected_test_result = {
         'report': {
             'result': {
                 'rev1': {
                     'a_test': {
                         'status': 'passed',
                         'valid': True
                     }
@@ skipping 20 matching lines @@
     master_name = 'm'
     builder_name = 'b'
     build_number = 1
     try_job_id = '3'
 
     try_job = WfTryJob.Create(master_name, builder_name, build_number).put()
 
     pipeline = MonitorTryJobPipeline()
     pipeline._UpdateTryJobResult(
         buildbucket_client.BuildbucketBuild.STARTED, master_name, builder_name,
-        build_number, TryJobType.TEST, try_job_id, 'url')
+        build_number, failure_type.TEST, try_job_id, 'url')
     try_job = WfTryJob.Get(master_name, builder_name, build_number)
     self.assertEqual(analysis_status.RUNNING, try_job.status)
 
   def testGetErrorForNoError(self):
     build_response = {
         'id': 1,
         'url': 'url',
         'status': 'COMPLETED',
         'completed_ts': '1454367574000000',
         'created_ts': '1454367570000000',
@@ skipping 141 matching lines @@
     }
 
     expected_error_dict = {
         'message': 'No result report was found.',
         'reason': MonitorTryJobPipeline.UNKNOWN
     }
 
     self.assertEqual(
         monitor_try_job_pipeline._GetError(build_response, None, False),
         (expected_error_dict, try_job_error.UNKNOWN))