[Findit] Refactor Findit pipeline.

appengine/findit/waterfall/schedule_compile_try_job_pipeline.py

+# Copyright 2016 The Chromium Authors. All rights reserved.

[Sharu Jiang, 2016/08/04 06:21:12]

I think that 'schedule_compile_try_job_pipeline' and
'shedule_test_try_job_pipeline' are very duplicate.

How about pass a type enum to a single pipeline? so we can avoid duplication.

[chanli, 2016/08/05 19:53:54]

They are not duplicates, in fact I have ScheduleTryJobPipeline as the base class
and they inherit from it.

Separating compile and test try jobs are in the plan of refactoring. 

+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from common.waterfall import failure_type
+from model.wf_try_job import WfTryJob
+from waterfall.schedule_try_job_pipeline import ScheduleTryJobPipeline
+
+
+class ScheduleCompileTryJobPipeline(ScheduleTryJobPipeline):
+  """A pipeline for scheduling a new try job for failed compile build."""
+
+  def _GetBuildProperties(
+      self, master_name, builder_name, build_number, good_revision,
+      bad_revision, try_job_type, suspected_revisions):
+    properties = super(ScheduleCompileTryJobPipeline, self)._GetBuildProperties(

[Sharu Jiang, 2016/08/04 06:21:12]

Why not just use self._GetBuildProperties? it's already inherited from
ScheduleTryJobPipeline. 

[chanli, 2016/08/05 19:53:53]

I'm not sure if I understand you... I need to add additional property for
compile only

+        master_name, builder_name, build_number, good_revision,
+        bad_revision, try_job_type, suspected_revisions)
+    properties['target_buildername'] = builder_name
+
+    return properties
+
+  # Arguments number differs from overridden method - pylint: disable=W0221
+  def run(
+      self, master_name, builder_name, build_number, good_revision,
+      bad_revision, try_job_type, compile_targets, suspected_revisions):

[lijeffrey, 2016/08/04 10:31:47]

so since this is for compile only, do we still need try_job_type? Same with
schedule_test_try_job_pipeline

[chanli, 2016/08/05 19:53:54]

we need try_job_type to choose the recipe in _GetBuildProperties. Although we
can also use a constant to do that...

+
+    properties = self._GetBuildProperties(
+        master_name, builder_name, build_number, good_revision, bad_revision,
+        try_job_type, suspected_revisions)
+    additional_parameters = {'compile_targets': compile_targets}
+
+    build_id = self._TriggerTryJob(
+        master_name, builder_name, properties, additional_parameters)
+
+    try_job_result = WfTryJob.Get(master_name, builder_name, build_number)
+    try_job_result.compile_results.append({'try_job_id': build_id})
+    try_job_result.try_job_ids.append(build_id)
+    try_job_result.put()
+
+    # Create a corresponding WfTryJobData entity to capture as much metadata as
+    # early as possible.
+    self._CreateTryJobData(
+        build_id, master_name, builder_name, build_number,
+        failure_type.GetDescriptionForFailureType(try_job_type),
+        bool(compile_targets), bool(suspected_revisions))
+
+    return build_id