[Findit] Refactor Findit pipeline.

appengine/findit/waterfall/identify_try_job_culprit_pipeline.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import logging
 
 from google.appengine.ext import ndb
 
 from common.git_repository import GitRepository
 from common.http_client_appengine import HttpClientAppengine as HttpClient
 from common.pipeline_wrapper import BasePipeline
+from common.waterfall import failure_type
 from model import analysis_status
 from model import result_status
 from model.wf_analysis import WfAnalysis
 from model.wf_try_job import WfTryJob
 from model.wf_try_job_data import WfTryJobData
-from waterfall.try_job_type import TryJobType
 from waterfall.send_notification_for_culprit_pipeline import (
     SendNotificationForCulpritPipeline)
 
 
 GIT_REPO = GitRepository(
     'https://chromium.googlesource.com/chromium/src.git', HttpClient())
 
 
 def _GetResultAnalysisStatus(analysis, result):
   """Returns the analysis status based on existing status and try job result.
@@ skipping 244 matching lines @@
   def run(
       self, master_name, builder_name, build_number, blame_list, try_job_type,
       try_job_id, result):
     """Identifies the information for failed revisions.
 
     Please refer to try_job_result_format.md for format check.
     """
     culprits = None
     if result and result.get('report'):
       try_job_data = WfTryJobData.Get(try_job_id)
-      if try_job_type == TryJobType.COMPILE:
+      if try_job_type == failure_type.COMPILE:
         # For compile failures, the try job will stop if one revision fails, so
         # the culprit will be the last revision in the result.
         failed_revision = _GetFailedRevisionFromCompileResult(result)
         failed_revisions = [failed_revision] if failed_revision else []
         culprits = self._GetCulpritInfo(failed_revisions)
         if culprits:
           result['culprit'] = {
               'compile': culprits[failed_revision]
           }
           try_job_data.culprits = {'compile': failed_revision}
       else:  # try_job_type is 'test'.
         culprit_map, failed_revisions = self._FindCulpritForEachTestFailure(
             blame_list, result)
         culprits = self._GetCulpritInfo(failed_revisions)
         if culprits:
           self._UpdateCulpritMapWithCulpritInfo(culprit_map, culprits)
           result['culprit'] = culprit_map
           try_job_data.culprits = self._GetCulpritDataForTest(culprit_map)
       try_job_data.put()
 
     @ndb.transactional
     def UpdateTryJobResult():
       try_job_result = WfTryJob.Get(master_name, builder_name, build_number)
       if culprits:
         result_to_update = (
             try_job_result.compile_results if
-            try_job_type == TryJobType.COMPILE else
+            try_job_type == failure_type.COMPILE else
             try_job_result.test_results)
         if (result_to_update and
             result_to_update[-1]['try_job_id'] == try_job_id):
           result_to_update[-1].update(result)
         else:  # pragma: no cover
           result_to_update.append(result)
       try_job_result.status = analysis_status.COMPLETED
       try_job_result.put()
 
     @ndb.transactional
@@ skipping 13 matching lines @@
         analysis.suspected_cls = updated_suspected_cls
         analysis.put()
 
     # Store try-job results.
     UpdateTryJobResult()
     # Add try-job results to WfAnalysis.
     UpdateWfAnalysisWithTryJobResult()
 
     _NotifyCulprits(master_name, builder_name, build_number, culprits)
     return result.get('culprit') if result else None